Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932588AbbDURiS (ORCPT ); Tue, 21 Apr 2015 13:38:18 -0400 Received: from exprod5og120.obsmtp.com ([64.18.0.137]:47610 "EHLO mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752150AbbDURiN (ORCPT ); Tue, 21 Apr 2015 13:38:13 -0400 MIME-Version: 1.0 In-Reply-To: <20150421154225.GC10164@leverpostej> References: <55310050.7000003@arm.com> <20150421154225.GC10164@leverpostej> From: Duc Dang Date: Tue, 21 Apr 2015 10:37:42 -0700 Message-ID: Subject: Re: [PATCH v5 3/4] documentation: dts: Add the device tree binding for APM X-Gene v1 PCIe MSI device tree node To: Mark Rutland Cc: Bjorn Helgaas , Arnd Bergmann , "grant.likely@linaro.org" , Liviu Dudau , Marc Zyngier , Feng Kan , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Loc Ho , "linux-arm-kernel@lists.infradead.org" , Tanmay Inamdar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3363 Lines: 92 On Tue, Apr 21, 2015 at 8:42 AM, Mark Rutland wrote: > > On Tue, Apr 21, 2015 at 05:04:23AM +0100, Duc Dang wrote: > > The driver for this binding is under 'drivers/pci/host/pci-xgene-msi.c' > > Please provide a bit of description of what this device is, and please > place the binding patch _before_ the driver and DTS patches. I will add in next version of the patch. > > > > Signed-off-by: Duc Dang > > Signed-off-by: Tanmay Inamdar > > --- > > .../devicetree/bindings/pci/xgene-pci-msi.txt | 63 ++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/xgene-pci-msi.txt > > > > diff --git a/Documentation/devicetree/bindings/pci/xgene-pci-msi.txt b/Documentation/devicetree/bindings/pci/xgene-pci-msi.txt > > new file mode 100644 > > index 0000000..0ffdcb3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/xgene-pci-msi.txt > > @@ -0,0 +1,63 @@ > > +* AppliedMicro X-Gene PCIe MSI interface > > + > > +Required properties: > > + > > +- compatible: should contain "apm,xgene1-msi" to identify the core. > > What does the core have to do with the MSI controller? 'core' here is the MSI controller block. I will use different word to avoid confusion with CPU core. > > > +- msi-controller: indicates that this is X-Gene1 PCIe MSI controller node > > +- reg: A list of physical base address and length for each set of controller > > + registers. > > How many? Which ones? In which order? Do you need reg-names? I will add these details in next version of the patch. > > > +- interrupts: A list of interrupt outputs of the controller. I will add these details in next version of the patch. > > How many? Which ones? In which order? Do you need interrupt-names? I will add these details in next version of the patch. > > You need to define these for *this particular binding*, in order for > them to actually define the contract. An abstract definition is > completely useless for writing or parsing a DT, and as such this > document is just noise. > > Please think about the purpose of this document, and write something > appropriate. > > [...] > > > + interrupts = < 0x0 0x10 0x4 > > + 0x0 0x11 0x4 > > + 0x0 0x12 0x4 > > + 0x0 0x13 0x4 > > + 0x0 0x14 0x4 > > + 0x0 0x15 0x4 > > + 0x0 0x16 0x4 > > + 0x0 0x17 0x4 > > + 0x0 0x18 0x4 > > + 0x0 0x19 0x4 > > + 0x0 0x1a 0x4 > > + 0x0 0x1b 0x4 > > + 0x0 0x1c 0x4 > > + 0x0 0x1d 0x4 > > + 0x0 0x1e 0x4 > > + 0x0 0x1f 0x4>; > > Nit: please bracket list entries individually. Thanks for your comment, I will address them on next version of the patch. > > Mark. Regards, Duc Dang. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/