Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933636AbbDUT62 (ORCPT ); Tue, 21 Apr 2015 15:58:28 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:33878 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932096AbbDUT6Y (ORCPT ); Tue, 21 Apr 2015 15:58:24 -0400 MIME-Version: 1.0 In-Reply-To: <1429644912.17259.31.camel@misato.fc.hp.com> References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com> <20150418013535.25237.4770.stgit@dwillia2-desk3.amr.corp.intel.com> <1429644912.17259.31.camel@misato.fc.hp.com> Date: Tue, 21 Apr 2015 12:58:22 -0700 Message-ID: Subject: Re: [Linux-nvdimm] [PATCH 04/21] nd: create an 'nd_bus' from an 'nfit_desc' From: Dan Williams To: Toshi Kani Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1639 Lines: 39 On Tue, Apr 21, 2015 at 12:35 PM, Toshi Kani wrote: > On Fri, 2015-04-17 at 21:35 -0400, Dan Williams wrote: > : >> + >> +static int nd_mem_init(struct nd_bus *nd_bus) >> +{ >> + struct nd_spa *nd_spa; >> + >> + /* >> + * For each SPA-DCR address range find its corresponding >> + * MEMDEV(s). From each MEMDEV find the corresponding DCR. >> + * Then, try to find a SPA-BDW and a corresponding BDW that >> + * references the DCR. Throw it all into an nd_mem object. >> + * Note, that BDWs are optional. >> + */ >> + list_for_each_entry(nd_spa, &nd_bus->spas, list) { >> + u16 spa_index = readw(&nd_spa->nfit_spa->spa_index); >> + int type = nfit_spa_type(nd_spa->nfit_spa); >> + struct nd_mem *nd_mem, *found; >> + struct nd_memdev *nd_memdev; >> + u16 dcr_index; >> + >> + if (type != NFIT_SPA_DCR) >> + continue; > > This function requires NFIT_SPA_DCR, SPA Range Structure with NVDIMM > Control Region GUID, for initializing an nd_mem object. However, > battery-backed DIMMs do not have such control region SPA. IIUC, the > NFIT spec does not require NFIT_SPA_DCR. > > Can you change this function to work with NFIT_SPA_PM as well? NFIT_SPA_PM ranges are handled separately from nd_mem_init(). See nd_region_create() in patch 10. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/