Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964874AbbDUU6A (ORCPT ); Tue, 21 Apr 2015 16:58:00 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:33501 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932490AbbDUU56 (ORCPT ); Tue, 21 Apr 2015 16:57:58 -0400 Message-ID: <5536B9D2.7030200@gmail.com> Date: Tue, 21 Apr 2015 22:57:54 +0200 From: Mateusz Kulikowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Joe Perches CC: apw@canonical.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() References: <1429481816-6664-1-git-send-email-mateusz.kulikowski@gmail.com> <1429481816-6664-3-git-send-email-mateusz.kulikowski@gmail.com> <1429492384.27863.13.camel@perches.com> In-Reply-To: <1429492384.27863.13.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 39 Hi Joe, On 20.04.2015 03:13, Joe Perches wrote: > On Mon, 2015-04-20 at 00:16 +0200, Mateusz Kulikowski wrote: >> Suggest using eth_zero_addr() or eth_broadcast_addr() instead of memset(). > > Hi again Mateusz > >> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] >> @@ -5042,6 +5042,22 @@ sub process { >> "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . $herecurr) >> } >> >> +# check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr >> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr >> + if ($^V && $^V ge 5.10.0 && >> + $line =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) { > > Because you are working with $line and not $stat, > the last /s isn't useful here. > > $line is always a single line. Perhaps it would be smarter to use (for both patches) $stat instead. This applies also to existing checks (like PREFER_ETHER_ADDR_COPY) so we can catch calls formatted like memset(very.long.structure->something.something_different42, 0xFF, ETH_ALEN); Regards, Mateusz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/