Message-ID: <1429655247.31675.20.camel@perches.com>
Subject: Re: [PATCH v2 2/2] checkpatch: suggest using eth_zero_addr() and
 eth_broadcast_addr()
From: Joe Perches <joe@perches.com>
To: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Cc: apw@canonical.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Tue, 21 Apr 2015 15:27:27 -0700
In-Reply-To: <5536C4C2.4000001@gmail.com>
References: <1429481816-6664-1-git-send-email-mateusz.kulikowski@gmail.com>
	 <1429481816-6664-3-git-send-email-mateusz.kulikowski@gmail.com>
	 <1429492384.27863.13.camel@perches.com> <5536B9D2.7030200@gmail.com>
	 <1429651348.31675.12.camel@perches.com> <5536C4C2.4000001@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1297
Lines: 41

On Tue, 2015-04-21 at 23:44 +0200, Mateusz Kulikowski wrote:
> On 21.04.2015 23:22, Joe Perches wrote:
> > On Tue, 2015-04-21 at 22:57 +0200, Mateusz Kulikowski wrote:
> (...)
> >>
> >> Perhaps it would be smarter to use (for both patches) $stat instead.
> >> This applies also to existing checks (like PREFER_ETHER_ADDR_COPY) 
> >> so we can catch calls formatted like
> >>
> >> memset(very.long.structure->something.something_different42,
> >>        0xFF, ETH_ALEN);
> > 
> > Yes, likely that's true.
> > 
> > checkpatch couldn't --fix it easily unless it's on a
> > single line though.
> 
> True, True; If you prefer $line and ability to --fix - I'll use that in v3

I suppose you could do both $line and $stat
and the fix would only work when it's on a
single line.

Perhaps something like this would work:

	if ($line =~ /whatever/ ||
	    (defined($stat) && $stat =~ /whatever/)) {
		if (WARN(...) &&
		    $fix) {
			fixed[$fixlinenr] =~ s/whatever/appropriate/;
		}
	}

No worries about getting 'round the the list.
It'll get got eventually.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/