Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965102AbbDUXzi (ORCPT ); Tue, 21 Apr 2015 19:55:38 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:35962 "EHLO mail-pd0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964865AbbDUXzg (ORCPT ); Tue, 21 Apr 2015 19:55:36 -0400 Date: Wed, 22 Apr 2015 08:55:52 +0900 From: Sergey Senozhatsky To: Marcin Jabrzyk Cc: minchan@kernel.org, ngupta@vflare.org, linux-kernel@vger.kernel.org, sergey.senozhatsky.work@gmail.com, akpm@linux-foundation.org, kyungmin.park@samsung.com Subject: Re: [PATCH] zram: remove obsolete ZRAM_DEBUG option Message-ID: <20150421235552.GA1628@swordfish> References: <1429615220-20676-1-git-send-email-m.jabrzyk@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429615220-20676-1-git-send-email-m.jabrzyk@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2086 Lines: 69 On (04/21/15 13:20), Marcin Jabrzyk wrote: > This config option doesn't provide any usage for zram. > agree, there is no pr_debug() in the current zram. so the change looks good to me. btw, same stands for zsmalloc (for the time being): #ifdef CONFIG_ZSMALLOC_DEBUG #define DEBUG #endif seems to be useless. and there is even no ZSMALLOC_DEBUG config option in mm/Kconfig. so let's return back to it and clean up after the merge window. -ss > Signed-off-by: Marcin Jabrzyk > --- > drivers/block/zram/Kconfig | 10 +--------- > drivers/block/zram/zram_drv.c | 4 ---- > 2 files changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/block/zram/Kconfig b/drivers/block/zram/Kconfig > index 6489c0fd0ea6..386ba3d1a6ee 100644 > --- a/drivers/block/zram/Kconfig > +++ b/drivers/block/zram/Kconfig > @@ -23,12 +23,4 @@ config ZRAM_LZ4_COMPRESS > default n > help > This option enables LZ4 compression algorithm support. Compression > - algorithm can be changed using `comp_algorithm' device attribute. > - > -config ZRAM_DEBUG > - bool "Compressed RAM block device debug support" > - depends on ZRAM > - default n > - help > - This option adds additional debugging code to the compressed > - RAM block device driver. > + algorithm can be changed using `comp_algorithm' device attribute. > \ No newline at end of file > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index fe67ebbe6c18..ea10f291d722 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -15,10 +15,6 @@ > #define KMSG_COMPONENT "zram" > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > -#ifdef CONFIG_ZRAM_DEBUG > -#define DEBUG > -#endif > - > #include > #include > #include > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/