Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965641AbbDVALd (ORCPT ); Tue, 21 Apr 2015 20:11:33 -0400 Received: from mga14.intel.com ([192.55.52.115]:5303 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965311AbbDVALb (ORCPT ); Tue, 21 Apr 2015 20:11:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,619,1422950400"; d="scan'208";a="683666237" Date: Tue, 21 Apr 2015 20:11:25 -0400 From: "ira.weiny" To: Michael Wang Cc: Roland Dreier , Sean Hefty , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, hal@dev.mellanox.co.il, Tom Tucker , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe , Doug Ledford Subject: Re: [PATCH v5 23/27] IB/Verbs: Use management helper cap_read_multi_sge() Message-ID: <20150422001124.GW15893@phlsvsds.ph.intel.com> References: <5534B8C9.506@profitbricks.com> <5534BBDF.1070609@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5534BBDF.1070609@profitbricks.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2547 Lines: 68 On Mon, Apr 20, 2015 at 10:42:07AM +0200, Michael Wang wrote: > > Introduce helper cap_read_multi_sge() to help us check if the port of an > IB device support RDMA Read Multiple Scatter-Gather Entries. > > Cc: Hal Rosenstock > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang Reviewed-by: Ira Weiny > --- > include/rdma/ib_verbs.h | 15 +++++++++++++++ > net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 ++- > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index d0ae08e..074f66d 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -1878,6 +1878,21 @@ static inline int cap_ipoib(struct ib_device *device, u8 port_num) > return rdma_tech_ib(device, port_num); > } > > +/** > + * cap_read_multi_sge - Check if the port of device has the capability > + * RDMA Read Multiple Scatter-Gather Entries. > + * > + * @device: Device to be checked > + * @port_num: Port number of the device > + * > + * Return 0 when port of the device don't support > + * RDMA Read Multiple Scatter-Gather Entries. > + */ > +static inline int cap_read_multi_sge(struct ib_device *device, u8 port_num) > +{ > + return !rdma_tech_iwarp(device, port_num); > +} > + > int ib_query_gid(struct ib_device *device, > u8 port_num, int index, union ib_gid *gid); > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > index a5bed5b..7711b7a 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c > @@ -117,7 +117,8 @@ static void rdma_build_arg_xdr(struct svc_rqst *rqstp, > > static int rdma_read_max_sge(struct svcxprt_rdma *xprt, int sge_count) > { > - if (rdma_tech_iwarp(xprt->sc_cm_id->device, xprt->sc_cm_id->port_num)) > + if (!cap_read_multi_sge(xprt->sc_cm_id->device, > + xprt->sc_cm_id->port_num)) > return 1; > else > return min_t(int, sge_count, xprt->sc_max_sge); > -- > 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/