Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933787AbbDVA5G (ORCPT ); Tue, 21 Apr 2015 20:57:06 -0400 Received: from mail-ig0-f178.google.com ([209.85.213.178]:35333 "EHLO mail-ig0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933696AbbDVA5E (ORCPT ); Tue, 21 Apr 2015 20:57:04 -0400 MIME-Version: 1.0 In-Reply-To: <20150421225723.GA5927@virgo.local> References: <1429565231-4609-1-git-send-email-hagen@jauu.net> <20150420215645.GC10191@pd.tnic> <20150421074212.GA25081@gmail.com> <20150421225723.GA5927@virgo.local> Date: Tue, 21 Apr 2015 17:57:03 -0700 X-Google-Sender-Auth: E1WDdcQfTPNuuIkVnlGS5zm67Vo Message-ID: Subject: Re: [PATCH RFC] x86: enforce inlining for atomics From: Linus Torvalds To: Hagen Paul Pfeifer Cc: Ingo Molnar , Borislav Petkov , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , Andrew Morton Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 834 Lines: 20 On Tue, Apr 21, 2015 at 3:57 PM, Hagen Paul Pfeifer wrote: > > Is it possible that gcc is bedeviled because of inline assembler > parts which brings confuse the internal scoring system? yes, I have this memory of having seen that before - the size heuristics for gcc getting confused by inlining. I'm wondering if maybe it uses the size of the string to approximate the size, or just uses some random variable. It might be a good idea to mark things that are basically just wrappers around a single (or a couple of) asm instruction to be always_inline. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/