MIME-Version: 1.0
In-Reply-To: <1429646153-20677-9-git-send-email-paulmck@linux.vnet.ibm.com>
References: <20150421195529.GA17864@linux.vnet.ibm.com> <1429646153-20677-1-git-send-email-paulmck@linux.vnet.ibm.com>
 <1429646153-20677-9-git-send-email-paulmck@linux.vnet.ibm.com>
From: Pranith Kumar <bobby.prani@gmail.com>
Date: Wed, 22 Apr 2015 01:22:23 -0400
Message-ID: <CAJhHMCC9f76-33VAQH11gDenBo7uukswAN2SrCPKUfxLXewdhg@mail.gmail.com>
Subject: Re: [PATCH tip/core/rcu 09/12] rcu: Break dependency of
 RCU_FANOUT_LEAF on RCU_FANOUT
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Lai Jiangshan <laijs@cn.fujitsu.com>,
        Dipankar Sarma <dipankar@in.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Howells <dhowells@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        Darren Hart <dvhart@linux.intel.com>,
        =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= <fweisbec@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1768
Lines: 52

On Tue, Apr 21, 2015 at 3:55 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
> From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
>
> RCU_FANOUT_LEAF's range and default values depend on the value of
> RCU_FANOUT, which at the time seemed like a cute way to save two lines
> of Kconfig code.  However, adding a dependency from both of these
> Kconfig parameters on RCU_EXPERT requires that RCU_FANOUT_LEAF operate
> correctly even if RCU_FANOUT is undefined.  This commit therefore
> allows RCU_FANOUT_LEAF to take on the full range of permitted values,
> even in cases where RCU_FANOUT is undefined.
>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
>  init/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index aa68d72fe051..35559e07db18 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -599,9 +599,11 @@ config RCU_FANOUT
>
>  config RCU_FANOUT_LEAF
>         int "Tree-based hierarchical RCU leaf-level fanout value"
> -       range 2 RCU_FANOUT if 64BIT
> -       range 2 RCU_FANOUT if !64BIT
> +       range 2 64 if 64BIT
> +       range 2 32 if !64BIT
>         depends on TREE_RCU || PREEMPT_RCU
> +       default 64 if 64BIT
> +       default 32 if !64BIT
>         default 16

What is the effect of this 'default 16' line? It is either 64 or 32
based on 64BIT, not sure when it is 16...

>         help
>           This option controls the leaf-level fanout of hierarchical
> --
> 1.8.1.5
>


-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/