MIME-Version: 1.0
In-Reply-To: <1429646153-20677-11-git-send-email-paulmck@linux.vnet.ibm.com>
References: <20150421195529.GA17864@linux.vnet.ibm.com> <1429646153-20677-1-git-send-email-paulmck@linux.vnet.ibm.com>
 <1429646153-20677-11-git-send-email-paulmck@linux.vnet.ibm.com>
From: Pranith Kumar <bobby.prani@gmail.com>
Date: Wed, 22 Apr 2015 01:25:07 -0400
Message-ID: <CAJhHMCC7aZ_pHhZ0g176+RpzyTw5hpwEQNbM9Fp-GHGgpBgiXQ@mail.gmail.com>
Subject: Re: [PATCH tip/core/rcu 11/12] rcu: Make RCU able to tolerate
 undefined CONFIG_RCU_FANOUT_LEAF
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Lai Jiangshan <laijs@cn.fujitsu.com>,
        Dipankar Sarma <dipankar@in.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        David Howells <dhowells@redhat.com>,
        Eric Dumazet <edumazet@google.com>,
        Darren Hart <dvhart@linux.intel.com>,
        =?UTF-8?B?RnLDqWTDqXJpYyBXZWlzYmVja2Vy?= <fweisbec@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 998
Lines: 24

On Tue, Apr 21, 2015 at 3:55 PM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:

> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 2e52502bfc95..a2f64e4fdb57 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -86,10 +86,10 @@ static void __init rcu_bootup_announce_oddness(void)
>                 pr_info("\tAdditional per-CPU info printed with stalls.\n");
>         if (RCU_NUM_LVLS >= 4)
>                 pr_info("\tFour(or more)-level hierarchy is enabled.\n");
> -       if (CONFIG_RCU_FANOUT_LEAF != 16)
> +       if (RCU_FANOUT_LEAF != 16)

So if CONFIG_RCU_FANOUT_LEAF is either by default 32 or 64, this check
against 16 for build-time adjustment is a bit misleading, no?

-- 
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/