Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965339AbbDVGtN (ORCPT ); Wed, 22 Apr 2015 02:49:13 -0400 Received: from mga14.intel.com ([192.55.52.115]:40574 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965280AbbDVGtL convert rfc822-to-8bit (ORCPT ); Wed, 22 Apr 2015 02:49:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,622,1422950400"; d="scan'208";a="559868810" From: "Drokin, Oleg" To: Christoph Hellwig CC: Boqun Feng , "" , "" , "" , Al Viro , "Dilger, Andreas" , Greg Kroah-Hartman , Jan Kara Subject: Re: [PATCH 1/2] vfs: export symbol 'getname' and 'putname' Thread-Topic: [PATCH 1/2] vfs: export symbol 'getname' and 'putname' Thread-Index: AQHQfK+QTxCXxEubcUGDCCSFZfh7bZ1Y/TSA//+VVpeAAHpPgA== Date: Wed, 22 Apr 2015 06:49:08 +0000 Message-ID: <83D1849E-D084-4BD6-9A99-720F8F13535A@intel.com> References: <1429674624-25922-1-git-send-email-boqun.feng@gmail.com> <1429674624-25922-2-git-send-email-boqun.feng@gmail.com> <20150422055311.GB3731@infradead.org> <498CF73A-6CB4-4C17-8953-B4AAA855A3DF@intel.com> <20150422063110.GA25768@infradead.org> In-Reply-To: <20150422063110.GA25768@infradead.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.201.178] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1196 Lines: 26 On Apr 22, 2015, at 2:31 AM, Christoph Hellwig wrote: > On Wed, Apr 22, 2015 at 06:27:11AM +0000, Drokin, Oleg wrote: >>> Nak on exporting symbols for broken staging code. Please get rid of >>> the ioctls looking up path names in horrible ways in the lustre code. >> >> For a reference, is there a good example of a non-horrible way to look up a pathname? > > Just dont do it from an ioctl, it's got an fd parameter for a reason. I know this is not going to be a popular opinion with you, but sometimes opening a file is just too expensive. 1 RPC roudntrip to open a file and then another one to close it. Also some files could not be opened (fs corruption). Anyway, I got your point and there will be a solution. I was just hoping there was a way to do it because what if e.g. I need to create something new, not do something with already existing stuff, certainly there's no way to get an fd from a not yet existing fs object. Bye, Oleg-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/