Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965874AbbDVJTv (ORCPT ); Wed, 22 Apr 2015 05:19:51 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:57430 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965712AbbDVJTt (ORCPT ); Wed, 22 Apr 2015 05:19:49 -0400 Date: Wed, 22 Apr 2015 10:19:41 +0100 From: Richard Fitzgerald To: Chanwoo Choi Cc: lee.jones@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, myungjoo.ham@samsung.com, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH 6/8] extcon: arizona: Add support for WM8998 and WM1814 Message-ID: <20150422091941.GA4303@opensource.wolfsonmicro.com> References: <1429619636-25478-1-git-send-email-rf@opensource.wolfsonmicro.com> <1429619636-25478-7-git-send-email-rf@opensource.wolfsonmicro.com> <55373766.6060106@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55373766.6060106@samsung.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 30 On Wed, Apr 22, 2015 at 02:53:42PM +0900, Chanwoo Choi wrote: > Hi Richard, > > > @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) > > break; > > } > > break; > > + case WM8998: > > + case WM1814: > > + info->micd_clamp = true; > > + info->hpdet_ip = 2; > > What is meaning of '2'? I prefer to use the definition for '2'. > '2' is the version number of the hpdet ip block in silicon. We're already using it as a raw number '0', '1' or '2' all over extcon-arizona.c so changing it here would mean making other patches to the file that aren't really part of adding WM8998 support, so I'd prefer not to change that as a side-effect of adding WM8998. > Except for upper one comment, looks good to me. > > Thanks, > Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/