Message-id: <55378326.4030707@samsung.com>
Date: Wed, 22 Apr 2015 13:16:54 +0200
From: Daniel Granat <d.granat@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.6.0
MIME-version: 1.0
To: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>, Julia.Lawall@lip6.fr,
        cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Cc: Gilles.Muller@lip6.fr, nicolas.palix@imag.fr
Subject: Re: [PATCH] Add coccinelle script that makes sure that tables are NULL
 terminated
References: <1425043313-15844-1-git-send-email-d.granat@samsung.com>
 <55378124.2060908@gmail.com>
In-reply-to: <55378124.2060908@gmail.com>
Content-type: text/plain; charset=iso-8859-2; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1635
Lines: 43

Ok, but I'm going to improve the script. New coccinelle release give my 
opportunity to simplify this a lot, so I'll send next version of my 
patch soon.

Best regards,
--
Daniel Granat
Junior Software Engineer
Samsung R&D Institute Poland (SRPOL)
Al. Armii Ludowej 14, 00-638 Warszawa, Poland

On 04/22/2015 01:08 PM, Krzysztof Kozlowski wrote:
> W dniu 27.02.2015 o 22:21, Daniel Granat pisze:
>> Signed-off-by: Daniel Granat <d.granat@samsung.com>
>> ---
>>    scripts/coccinelle/misc/device_id_tables.cocci | 95 ++++++++++++++++++++++++++
>>    1 file changed, 95 insertions(+)
>>    create mode 100644 scripts/coccinelle/misc/device_id_tables.cocci
>
> I like the idea and I think it is useful.
> Tested-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com>
>
> However applying the patch gave some warnings:
>
> Applying: Add coccinelle script that makes sure that tables are NULL terminated
> /home/dev/linux/linux/.git/rebase-apply/patch:64: space before tab in indent.
>          	coccilib.report.print_report(p1[0],msg)
> /home/dev/linux/linux/.git/rebase-apply/patch:89: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:99: trailing whitespace.
> struct matched_name arr[] = {
> /home/dev/linux/linux/.git/rebase-apply/patch:106: new blank line at EOF.
> +
> warning: 4 lines add whitespace errors.
>
> Best regards,
> Krzysztof
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/