Message-ID: <1429712309.32612.10.camel@perches.com>
Subject: Re: [PATCH 2/3 V2] time: allow gcc to fold constants when using
From: Joe Perches <joe@perches.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Nicholas Mc Guire <hofrat@osadl.org>, Michal Marek <mmarek@suse.cz>,
        Masahiro Yamada <yamada.m@jp.panasonic.com>,
        Sam Ravnborg <sam@ravnborg.org>, "H. Peter Alvin" <hpa@zytor.com>,
        John Stultz <john.stultz@linaro.org>, Andrew Hunter <ahh@google.com>,
        Paul Turner <pjt@google.com>, Aaron Sierra <asierra@xes-inc.com>,
        Brian Norris <computersforpeace@gmail.com>,
        linux-kernel@vger.kernel.org
Date: Wed, 22 Apr 2015 07:18:29 -0700
In-Reply-To: <alpine.DEB.2.11.1504221356340.13914@nanos>
References: <1428840815-21974-1-git-send-email-hofrat@osadl.org>
	 <1428840815-21974-3-git-send-email-hofrat@osadl.org>
	 <alpine.DEB.2.11.1504221356340.13914@nanos>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 30

On Wed, 2015-04-22 at 14:00 +0200, Thomas Gleixner wrote:
> On Sun, 12 Apr 2015, Nicholas Mc Guire wrote:
> > +extern unsigned long __msecs_to_jiffies(const unsigned int m);
> > +#if HZ <= MSEC_PER_SEC && !(MSEC_PER_SEC % HZ)
> > +static inline unsigned long _msecs_to_jiffies(const unsigned int m)
> > +{
> 
> This should move the comments explaining the logic for each variant as
> well.
[]
> It'd be nice to have this as two patches:
> 
> 1) Factor out the code into inline helpers w/o adding anything

It also might be nice to use a single static inline
with #ifdef blocks inside that inline rather than
have 3 separate static inline msecs_to_jiffies.

> 2) Add the __builtin_constant_p() check

And please add the usecs_to_jiffies variants in a
similar patch set.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/