Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934176AbbDVOoP (ORCPT ); Wed, 22 Apr 2015 10:44:15 -0400 Received: from www.linutronix.de ([62.245.132.108]:34385 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933164AbbDVOoL (ORCPT ); Wed, 22 Apr 2015 10:44:11 -0400 Date: Wed, 22 Apr 2015 16:44:09 +0200 (CEST) From: Thomas Gleixner To: Nicholas Mc Guire cc: Nicholas Mc Guire , Michal Marek , Masahiro Yamada , Sam Ravnborg , "H. Peter Alvin" , Joe Perches , John Stultz , Andrew Hunter , Paul Turner , Aaron Sierra , Brian Norris , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3 V2] time: allow gcc to fold constants when using In-Reply-To: <20150422143618.GA28213@opentech.at> Message-ID: References: <1428840815-21974-1-git-send-email-hofrat@osadl.org> <1428840815-21974-3-git-send-email-hofrat@osadl.org> <20150422143618.GA28213@opentech.at> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 36 On Wed, 22 Apr 2015, Nicholas Mc Guire wrote: > On Wed, 22 Apr 2015, Thomas Gleixner wrote: > > > On Sun, 12 Apr 2015, Nicholas Mc Guire wrote: > > > +extern unsigned long __msecs_to_jiffies(const unsigned int m); > > > +#if HZ <= MSEC_PER_SEC && !(MSEC_PER_SEC % HZ) > > > +static inline unsigned long _msecs_to_jiffies(const unsigned int m) > > > +{ > > > > This should move the comments explaining the logic for each variant as > > well. > > should be covered by [PATCH 3/3 V2] time: update msecs_to_jiffies doc and move to kernel-doc Well, it's covered but it makes no sense patch wise. > > 1) Factor out the code into inline helpers w/o adding anything > > > > 2) Add the __builtin_constant_p() check > > > > so basically 1) is refactoring only and 2) is the actual > change keept at a minimum or what is the intent of this split ? Right. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/