Date: Wed, 22 Apr 2015 11:24:55 -0600
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Michael Wang <yun.wang@profitbricks.com>
Cc: Roland Dreier <roland@kernel.org>, Sean Hefty <sean.hefty@intel.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
        hal@dev.mellanox.co.il, Tom Tucker <tom@opengridcomputing.com>,
        Steve Wise <swise@opengridcomputing.com>,
        Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
        Christoph Raisch <raisch@de.ibm.com>,
        Mike Marciniszyn <infinipath@intel.com>, Eli Cohen <eli@mellanox.com>,
        Faisal Latif <faisal.latif@intel.com>,
        Jack Morgenstein <jackm@dev.mellanox.co.il>,
        Or Gerlitz <ogerlitz@mellanox.com>, Haggai Eran <haggaie@mellanox.com>,
        Ira Weiny <ira.weiny@intel.com>, Tom Talpey <tom@talpey.com>,
        Doug Ledford <dledford@redhat.com>
Subject: Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()
Message-ID: <20150422172455.GF19500@obsidianresearch.com>
References: <5534B8C9.506@profitbricks.com>
 <5534BBC2.4010902@profitbricks.com>
 <20150422054058.GB29609@obsidianresearch.com>
 <553760A8.2090802@profitbricks.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <553760A8.2090802@profitbricks.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1181
Lines: 30

On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote:
> 
> On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
> > On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
> >  
> >> Introduce helper cap_ipoib() to help us check if the port of an
> >> IB device support IP over Infiniband.
> > 
> > I thought we were dropping this in favor of listing the actual
> > features the ULP required unconditionally? One of my messages had the
> > start of a list..
> 
> Shall we drop it now or wait until the mechanism introduced?
> 
> Just wondering the requirement of ULP could be similar to the
> requirement of management, isn't it? if the device can tell
> which ULP it support, then may be a cap_XX() make sense in here?

You have to audit the ipoib dirver and see what core functions it
calls that have cap requirements themselves.

At least SA, multicast and CM. It also requires cap_ib_ah() or
whatever we called that.

JAson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/