Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966322AbbDVRaS (ORCPT ); Wed, 22 Apr 2015 13:30:18 -0400 Received: from skprod2.natinst.com ([130.164.80.23]:52267 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965881AbbDVRaP (ORCPT ); Wed, 22 Apr 2015 13:30:15 -0400 Date: Wed, 22 Apr 2015 12:29:44 -0500 From: Ben Shelton To: dwmw2@infradead.org, computersforpeace@gmail.com, dedekind1@gmail.com, adrian.hunter@intel.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: joshc@ni.com, xander.huff@ni.com, punnaiah.choudary.kalluri@xilinx.com Subject: Adding subpage support to NAND driver -- backwards compatibility concerns Message-ID: <20150422172944.GA4134@bshelton-desktop> MIME-Version: 1.0 User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/22/2015 12:29:46 PM, Serialize by Router on US-AUS-MGWOut1/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/22/2015 12:29:46 PM, Serialize complete at 04/22/2015 12:29:46 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-04-22_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 30 Hi all, We're currently carrying a patch out of tree to add subpage read and write support to the pl353_nand driver. Xilinx is currently working to mainline this driver; see http://www.spinics.net/lists/devicetree/msg76307.html We'd like to upstream our patch, but my concern is that UBIFS behaves differently when it knows that the flash device supports subpages. I have a couple of questions related to that: - I know from experience that bad things happen when you use a kernel without subpage support with an UBIFS filesystem that was formatted with subpage support. Is it safe to do the opposite (kernel with subpage support / UBIFS filesystem formatted without subpage support)? - Assuming that it isn't safe, what's the best way to add subpage support to this driver in an upstreamable way / without breaking people? Would it be sufficient to add subpage support as a Kconfig option that's disabled by default with a strongly-worded message describing the consequences of enabling it? Thanks, Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/