Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757483AbbDVSWG (ORCPT ); Wed, 22 Apr 2015 14:22:06 -0400 Received: from mail-ig0-f175.google.com ([209.85.213.175]:34811 "EHLO mail-ig0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754715AbbDVSWD (ORCPT ); Wed, 22 Apr 2015 14:22:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150422171005.GA1020@jtriplet-mobl1> References: <1429720808-7173-1-git-send-email-dvlasenk@redhat.com> <1429720808-7173-2-git-send-email-dvlasenk@redhat.com> <20150422171005.GA1020@jtriplet-mobl1> Date: Wed, 22 Apr 2015 11:22:02 -0700 X-Google-Sender-Auth: kCykk9fZJCi4N50NOeMbTtsP5V8 Message-ID: Subject: Re: [PATCH 2/2] x86/asm/entry/32: Remove unnecessary optimization in stub32_clone From: Linus Torvalds To: Josh Triplett Cc: Andy Lutomirski , Denys Vlasenko , Ingo Molnar , Steven Rostedt , Borislav Petkov , "H. Peter Anvin" , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , X86 ML , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 28 On Wed, Apr 22, 2015 at 10:10 AM, Josh Triplett wrote: > > I do think my two-patch HAVE_COPY_THREAD_TLS series should go in fixing > this Ugh, I absolutely detesrt that patch. Don't make random crazy function signatures that depend on some config option. That's just evil. The patch is a mess of #ifdef's and should be shot in the head and staked with a silver stake to make sure it never re-appears. Either: (a) make the change for every architecture (b) have side-by-side interfaces. With different names! but not that disgusting "the calling conventions of these random functions are different on different architectures and we use a config flag to distinguish the cases". Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/