Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757928AbbDVTF2 (ORCPT ); Wed, 22 Apr 2015 15:05:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34353 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757425AbbDVTFY (ORCPT ); Wed, 22 Apr 2015 15:05:24 -0400 Date: Wed, 22 Apr 2015 21:05:20 +0200 From: "Luis R. Rodriguez" To: Doug Ledford Cc: Jason Gunthorpe , Andy Lutomirski , mike.marciniszyn@intel.com, infinipath@intel.com, linux-rdma@vger.kernel.org, awalls@md.metrocast.net, Toshi Kani , "H. Peter Anvin" , Ingo Molnar , "linux-kernel@vger.kernel.org" , Hal Rosenstock , Sean Hefty , Suresh Siddha , Rickard Strandqvist , Roland Dreier , Juergen Gross , Mauro Carvalho Chehab , Borislav Petkov , Mel Gorman , Vlastimil Babka , Davidlohr Bueso , Dave Hansen , Jean-Christophe Plagniol-Villard , Thomas Gleixner , Ville Syrj?l? , Linux Fbdev development list , linux-media@vger.kernel.org, X86 ML , mcgrof@do-not-panic.com Subject: Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR Message-ID: <20150422190520.GL5622@wotan.suse.de> References: <20150421224601.GY5622@wotan.suse.de> <20150421225732.GA17356@obsidianresearch.com> <20150421233907.GA5622@wotan.suse.de> <20150422053939.GA29609@obsidianresearch.com> <20150422152328.GB5622@wotan.suse.de> <20150422161755.GA19500@obsidianresearch.com> <1429728791.121496.10.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429728791.121496.10.camel@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2747 Lines: 62 On Wed, Apr 22, 2015 at 02:53:11PM -0400, Doug Ledford wrote: > On Wed, 2015-04-22 at 10:17 -0600, Jason Gunthorpe wrote: > > On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote: > > > On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > > > > On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: > > > > > > Mike, do you think the time is right to just remove the iPath driver? > > > > > > > > > > With PAT now being default the driver effectively won't work > > > > > with write-combining on modern kernels. Even if systems are old > > > > > they likely had PAT support, when upgrading kernels PAT will work > > > > > but write-combing won't on ipath. > > > > > > > > Sorry, do you mean the driver already doesn't get WC? Or do you mean > > > > after some more pending patches are applied? > > > > > > No, you have to consider the system used and the effects of calls used > > > on the driver in light of this table: > > > > So, just to be clear: > > > > At some point Linux started setting the PAT bits during > > ioremap_nocache, which overrides MTRR, and at that point the driver > > became broken on all PAT capable systems? > > > > Not only that, but we've only just noticed it now, and no user ever > > complained? > > > > So that means either no users exist, or all users are on non-PAT > > systems? > > > > This driver only works on x86-64 systems. Are there any x86-64 systems > > that are not PAT capable? IIRC even the first Opteron had PAT, but my > > memory is fuzzy from back then :| > > > > > Another option in order to enable this type of checks at run time > > > and still be able to build the driver on standard distributions and > > > just prevent if from loading on PAT systems is to have some code in > > > place which would prevent the driver from loading if PAT was > > > enabled, this would enable folks to disable PAT via a kernel command > > > line option, and if that was used then the driver probe would > > > complete. > > > > This seems like a reasonble option to me. At the very least we might > > learn if anyone is still using these cards. > > > > I'd also love to remove the driver if it turns out there are actually > > no users. qib substantially replaces it except for a few very old > > cards. > > To be precise, the split is that ipath powers the old HTX bus cards that > only work in AMD systems, Do those systems have PAT support? CAn anyone check if PAT is enabled if booted on a recent kernel? Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/