Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934491AbbDVTNk (ORCPT ); Wed, 22 Apr 2015 15:13:40 -0400 Received: from g4t3425.houston.hp.com ([15.201.208.53]:22748 "EHLO g4t3425.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934460AbbDVTNh convert rfc822-to-8bit (ORCPT ); Wed, 22 Apr 2015 15:13:37 -0400 From: "Elliott, Robert (Server Storage)" To: Dan Williams , "linux-nvdimm@lists.01.org" CC: Neil Brown , Greg KH , "linux-kernel@vger.kernel.org" Subject: RE: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices Thread-Topic: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices Thread-Index: AQHQeXiJFYiCs1g/Ekuv7h/xRsYAyJ1ZbJlQ Date: Wed, 22 Apr 2015 19:12:18 +0000 Message-ID: <94D0CD8314A33A4D9D801C0FE68B40295A8BE89F@G9W0745.americas.hpqcorp.net> References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com> <20150418013655.25237.41353.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: <20150418013655.25237.41353.stgit@dwillia2-desk3.amr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [16.210.48.26] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1245 Lines: 40 > -----Original Message----- > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of > Dan Williams > Sent: Friday, April 17, 2015 8:37 PM > To: linux-nvdimm@lists.01.org > Subject: [Linux-nvdimm] [PATCH 19/21] nd: infrastructure for btt devices > ... > +/* > + * btt_sb_checksum: compute checksum for btt info block > + * > + * Returns a fletcher64 checksum of everything in the given info block > + * except the last field (since that's where the checksum lives). > + */ > +u64 btt_sb_checksum(struct btt_sb *btt_sb) > +{ > + u64 sum, sum_save; > + > + sum_save = btt_sb->checksum; > + btt_sb->checksum = 0; > + sum = nd_fletcher64(btt_sb, sizeof(*btt_sb)); > + btt_sb->checksum = sum_save; > + return sum; > +} > +EXPORT_SYMBOL(btt_sb_checksum); ... Of all the functions with prototypes in nd.h, this is the only function that doesn't have a name starting with nd_. Following such a convention helps ease setting up ftrace filters. --- Robert Elliott, HP Server Storage -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/