Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757534AbbDVUqi (ORCPT ); Wed, 22 Apr 2015 16:46:38 -0400 Received: from arrakis.dune.hu ([78.24.191.176]:43296 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751793AbbDVUqe (ORCPT ); Wed, 22 Apr 2015 16:46:34 -0400 MIME-Version: 1.0 In-Reply-To: <20150422141721.D3F8C1A242E@localhost.localdomain> References: <20150422141721.D3F8C1A242E@localhost.localdomain> From: Jonas Gorski Date: Wed, 22 Apr 2015 22:46:05 +0200 Message-ID: Subject: Re: [PATCH v2] spi: fsl-spi: use of_iomap() to map parameter ram on CPM1 To: Christophe Leroy Cc: Mark Brown , "linux-kernel@vger.kernel.org" , linuxppc-dev@lists.ozlabs.org, linux-spi@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1614 Lines: 39 Hi Christophe, On Wed, Apr 22, 2015 at 4:17 PM, Christophe Leroy wrote: > On CPM2, the SPI parameter RAM is dynamically allocated in the > dualport RAM whereas in CPM1, it is statically allocated to a default > address with capability to relocate it somewhere else via the use of > CPM micropatch. The address of the parameter RAM is given by the boot > loader and expected to be mapped via of_iomap() > > In the current implementation, in function fsl_spi_cpm_get_pram() > there is a confusion between the SPI_BASE register and the base of the > SPI parameter RAM. Fortunatly, it is working properly with MPC866 and > MPC885 because they do set SPI_BASE, but on MPC860 and other old > MPC8xx that doesn't set SPI_BASE, pram_ofs is not properly set. > Also, the parameter RAM is not properly mapped with of_iomap() as it > should but still gets accessible by chance through the full RAM which > is mapped from somewhere else. > > This patch applies to the SPI driver the same principle as for the > CPM UART: when the CPM is of type CPM1, we simply do an of_iomap() of > the area provided via the device tree. > > Signed-off-by: Christophe Leroy > > --- > v2: Use devm_ioremap_resource() instead of_iomap() Your subject and commitlog still talk about using of_iomap(), you need to update them too. Regards Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/