Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933559AbbDWDVx (ORCPT ); Wed, 22 Apr 2015 23:21:53 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51771 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932082AbbDWDVw (ORCPT ); Wed, 22 Apr 2015 23:21:52 -0400 Date: Wed, 22 Apr 2015 20:28:42 -0700 From: Andrew Morton To: Gavin Guo Cc: Christoph Lameter , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel Subject: Re: [PATCH v2] mm/slab_common: Support the slub_debug boot option on specific object size Message-Id: <20150422202842.47cb7940.akpm@linux-foundation.org> In-Reply-To: References: <1429691618-13884-1-git-send-email-gavin.guo@canonical.com> <20150422140039.19812721dff3fec674dc5134@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2007 Lines: 45 On Thu, 23 Apr 2015 11:10:40 +0800 Gavin Guo wrote: > >> for (i = KMALLOC_SHIFT_LOW; i <= KMALLOC_SHIFT_HIGH; i++) { > >> if (!kmalloc_caches[i]) { > >> - kmalloc_caches[i] = create_kmalloc_cache(NULL, > >> + kmalloc_caches[i] = create_kmalloc_cache( > >> + kmalloc_names[i], > >> 1 << i, flags); > >> } > > > > You could do something like > > > > kmalloc_caches[i] = create_kmalloc_cache( > > kmalloc_names[i], > > kstrtoul(kmalloc_names[i] + 8), > > flags); > > > > here, and remove those weird "96" and "192" cases. > > Thanks for your reply. I'm not sure if I am following your idea. Would you > mean to simply replace the string like: > > kmalloc_caches[1] = create_kmalloc_cache( > kmalloc_names[1], 96, flags); > as follows: > > kmalloc_caches[1] = create_kmalloc_cache( > kmalloc_names[1], > kstrtoul(kmalloc_names[i] + 8), > flags); > > or if you like to merge the last 2 if conditions for 96 and 192 cases to > the first if condition check: > > if (!kmalloc_caches[i]) { > kmalloc_caches[i] = create_kmalloc_cache(NULL, > 1 << i, flags); > } The latter - initialize all the caches in a single loop. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/