Message-ID: <553877FB.4040507@linux.vnet.ibm.com>
Date: Thu, 23 Apr 2015 10:11:31 +0530
From: Shreyas B Prabhu <shreyas@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: mpe@ellerman.id.au, agraf@suse.de
CC: ego@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] kvm: powerpc: Fix ppc64_defconfig + PPC_POWERNV=n build
 error
References: <1429181889-1448-1-git-send-email-shreyas@linux.vnet.ibm.com>
In-Reply-To: <1429181889-1448-1-git-send-email-shreyas@linux.vnet.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1553
Lines: 40

Any suggestions on this?

On Thursday 16 April 2015 04:28 PM, Shreyas B. Prabhu wrote:
> kvm_no_guest function calls power7_wakeup_loss to put the thread into
> the deepest supported idle state. power7_wakeup_loss is defined in
> arch/powerpc/kernel/idle_power7.S, which is compiled only when PPC_P7_NAP=y.
> And PPC_P7_NAP is selected when PPC_POWERNV=y.
> Hence in cases where PPC_POWERNV=n and KVM_BOOK3S_64_HV=y we see the
> following error:
> 
> arch/powerpc/kvm/built-in.o: In function `kvm_no_guest':
> arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x42c): undefined reference to `power7_wakeup_loss'
> 
> Fix this by adding PPC_POWERNV as a dependency for KVM_BOOK3S_64_HV.
> 
> Signed-off-by: Shreyas B. Prabhu <shreyas@linux.vnet.ibm.com>
> ---
>  arch/powerpc/kvm/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index 11850f3..b3b3d9f 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -75,7 +75,7 @@ config KVM_BOOK3S_64
> 
>  config KVM_BOOK3S_64_HV
>  	tristate "KVM support for POWER7 and PPC970 using hypervisor mode in host"
> -	depends on KVM_BOOK3S_64
> +	depends on KVM_BOOK3S_64 && PPC_POWERNV
>  	select KVM_BOOK3S_HV_POSSIBLE
>  	select MMU_NOTIFIER
>  	select CMA
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/