Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755107AbbDWHOu (ORCPT ); Thu, 23 Apr 2015 03:14:50 -0400 Received: from david.siemens.de ([192.35.17.14]:33604 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752674AbbDWHOs (ORCPT ); Thu, 23 Apr 2015 03:14:48 -0400 Message-ID: <55389BDB.3060307@siemens.com> Date: Thu, 23 Apr 2015 09:14:35 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Mike Galbraith CC: Steven Rostedt , Sebastian Andrzej Siewior , RT , Linux Kernel Mailing List Subject: Re: [PATCH RT 3.18] irq_work: Provide a soft-irq based queue References: <552FC1FE.4020406@siemens.com> <552FC6B1.1040000@linutronix.de> <552FC72A.8060709@siemens.com> <20150416111041.66043164@gandalf.local.home> <552FD55F.8000105@siemens.com> <552FE320.6050601@siemens.com> <1429517036.3226.9.camel@gmail.com> <1429769505.3419.9.camel@gmail.com> <5538915C.8010904@siemens.com> <1429772313.3419.38.camel@gmail.com> In-Reply-To: <1429772313.3419.38.camel@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 38 On 2015-04-23 08:58, Mike Galbraith wrote: > On Thu, 2015-04-23 at 08:29 +0200, Jan Kiszka wrote: >> >>> void irq_work_tick(void) >>> { >>> -#ifdef CONFIG_PREEMPT_RT_FULL >>> - irq_work_run_list(this_cpu_ptr(&lazy_list)); >>> -#else >>> - struct llist_head *raised = &__get_cpu_var(raised_list); >>> + struct llist_head *raised = this_cpu_ptr(&raised_list); >>> >>> - if (!llist_empty(raised) && !arch_irq_work_has_interrupt()) >>> + if (!llist_empty(raised) && >>> (!arch_irq_work_has_interrupt() || >>> + IS_ENABLED(CONFIG_PREEMPT_RT_FULL))) >> >> OK, that additional condition is addressing archs that don't have >> irq_work support and fall back to the timer, right? > > How will ever run if it is not run in either irq_work_run() or > irq_work_tick()? There are two choices, we better pick one. Ah, now I see it. Indeed. OK, will run through your fix and suggestions and come up with a new version. Thanks, Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/