Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756847AbbDWHuN (ORCPT ); Thu, 23 Apr 2015 03:50:13 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:32826 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756745AbbDWHuJ convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2015 03:50:09 -0400 MIME-Version: 1.0 In-Reply-To: <87F60714EC601C4C83DFF1D2E3D390A027284081@NTXXIAMBX02.xacn.micron.com> References: <87F60714EC601C4C83DFF1D2E3D390A02728255E@NTXXIAMBX02.xacn.micron.com> <20150422175108.GX32500@ld-irv-0074> <87F60714EC601C4C83DFF1D2E3D390A027284081@NTXXIAMBX02.xacn.micron.com> Date: Thu, 23 Apr 2015 09:50:08 +0200 Message-ID: Subject: Re: [PATCH 2/6] mtd: diskonchip: don't call nand_scan_bbt() directly From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?B?UGV0ZXIgUGFuIOa9mOagiyAocGV0ZXJwYW5kb25nKQ==?= Cc: Brian Norris , "linux-mtd@lists.infradead.org" , "dwmw2@infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1506 Lines: 38 On 23 April 2015 at 02:30, Peter Pan 潘栋 (peterpandong) wrote: > On Thu, Apr 23, 2015 at 01:51:27PM +0000, Brian Norris wrote: >> >> On Thu, Apr 16, 2015 at 02:11:24AM +0000, Peter Pan 潘栋 (peterpandong) >> wrote: >> > The diskonchip driver almost uses the default nand_base hooks as-is, >> > except that it provides custom on-flash BBT descriptors and avoids >> using >> > factory-marked bad blockers. >> > >> > So let's refactor the BBT initialization code into a private >> 'late_init' >> > hook which handles all the private details. Note the usage of >> > NAND_SKIP_BBTSCAN, which allows us to defer the BBT scan until we've >> > prepared everything. >> > >> > Signed-off-by: Brian Norris >> > Signed-off-by: Peter Pan >> >> Why are you just resending my patch? You could Ack/Review/Test it >> instead. (Did you test it?) > > My work is in the 6th patch. > I already tested the patch with micron own nand controller. I don't have > platform with docg4 or diskonchip controller. So the BBT and nand_base.c > part is covered while docg4.c and diskonchip.c not. You can use patch format's comment place to post sth like "Depends on 5 XXX patches from Brian" -- Rafał -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/