Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753779AbbDWIhY (ORCPT ); Thu, 23 Apr 2015 04:37:24 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:34544 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754528AbbDWIhI (ORCPT ); Thu, 23 Apr 2015 04:37:08 -0400 Message-ID: <5538AF29.2080901@profitbricks.com> Date: Thu, 23 Apr 2015 10:36:57 +0200 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jason Gunthorpe , Doug Ledford CC: Liran Liss , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hal@dev.mellanox.co.il" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , "raisch@de.ibm.com" , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran , Ira Weiny , Tom Talpey Subject: Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers References: <5534B8C9.506@profitbricks.com> <1429714792.45956.110.camel@redhat.com> <20150422165724.GC19500@obsidianresearch.com> In-Reply-To: <20150422165724.GC19500@obsidianresearch.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1706 Lines: 46 On 04/22/2015 06:57 PM, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 10:59:52AM -0400, Doug Ledford wrote: > >>> 2)The name rdma_tech_* is lame. >>> rdma_transport_*(), adhering to the above (*) remark, is much better. >>> For example, both IB and ROCE *do* use the same transport. >> >> I especially want to second this. I haven't really been happy with the >> rdma_tech_* names at all. > > I'm not excited about the names either.. > > cap_ is bad because it pollutes the global namespace. > > rdma_tech_ .. as used, this is selecting the standard the port > implements. The word 'standard' is a better choice than 'transport', > and 'technology' is often synonymous with 'standard'. Meh. > > I've said it already, but this patch set has probably gotten too > big. If we could just do the cap conversion without messing with other > stuff, or adding rdma_tech, that would really be the best. > > Nobody seems to like the rdma_tech parts of this series. > > I'd also drop '[PATCH v5 09/27] IB/Verbs: Reform IB-core > verbs/uverbs_cmd/sysfs' - that is UAPI stuff, it could be done as a > followup someday, not worth the risk right now. There won't be risk... the logical is clear that they will return the same result, but I'll drop the modification on link_layer_show() and ib_uverbs_query_port() anyway, since they are just try to get the link-layer type and we are not going to erase that helper anymore. Regards, Michael Wang > > Jason > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/