Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965409AbbDWMDf (ORCPT ); Thu, 23 Apr 2015 08:03:35 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:32981 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965378AbbDWMDd convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2015 08:03:33 -0400 Subject: Re: [PATCH 1/3] of: Allow OF to be enabled if COMPILE_TEST to increase coverage Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: text/plain; charset=utf-8 From: Pantelis Antoniou In-Reply-To: Date: Thu, 23 Apr 2015 15:03:28 +0300 Cc: Geert Uytterhoeven , Grant Likely , Rob Herring , Arnd Bergmann , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Transfer-Encoding: 8BIT Message-Id: <0C5158C3-2BD3-4EC6-B1AC-B669F30B4C34@konsulko.com> References: <1428245965-19618-1-git-send-email-geert@linux-m68k.org> <1428245965-19618-2-git-send-email-geert@linux-m68k.org> To: Rob Herring X-Mailer: Apple Mail (2.2070.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2349 Lines: 71 Hi Rob, > On Apr 6, 2015, at 16:13 , Rob Herring wrote: > > +Pantelis > > On Sun, Apr 5, 2015 at 9:59 AM, Geert Uytterhoeven wrote: >> Currently the OF configuration symbol is explicitly selected on >> architectures that support device trees and/or Open Firmware. >> However, there's no technical reason to limit the device tree >> infrastructure to these architectures. Hence allow OF to be enabled when >> compile testing, to increase compile coverage. >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/of/Kconfig | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig >> index 7bcaeec876c0c3a5..4c98f14694458794 100644 >> --- a/drivers/of/Kconfig >> +++ b/drivers/of/Kconfig >> @@ -2,7 +2,11 @@ config DTC >> bool >> >> config OF >> - bool >> + bool "Device Tree and Open Firmware support" if COMPILE_TEST > > Actually, I think we want to just make this always visible. There are > now use cases with overlays where we may want to enable DT even if the > architecture is not booting with DT. However, there may be more work > needed to do that. > We have to decouple the notion of CONFIG_OF of the following two different things. 1. I’m booting using a device tree blob. 2. I’m using the in-kernel live device tree to represent my hardware device state. so CONFIG_OF_DTB_BLOB for the first case, and CONFIG_OF for the second. Up to now we bundle those two together. > Rob > Regards — Pantelis >> + help >> + This option enables the device tree infrastructure. >> + If is automatically selected by platforms that need it, but can >> + be enabled manually to increase compile-coverage. >> >> menu "Device Tree and Open Firmware support" >> depends on OF >> -- >> 1.9.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/