Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965832AbbDWNET (ORCPT ); Thu, 23 Apr 2015 09:04:19 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:60649 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbbDWNEM (ORCPT ); Thu, 23 Apr 2015 09:04:12 -0400 X-Sasl-enc: 92pYqczOe3qWBiYoYuYkVedqutJMUn0bWmz+YVj8nlCK 1429794250 Date: Thu, 23 Apr 2015 15:04:09 +0200 From: Greg KH To: Pantelis Antoniou Cc: Rob Herring , Grant Likely , Andrew Morton , Matt Porter , Koen Kooi , Guenter Roeck , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v2 3/4] of: overlay: Add sysfs attributes Message-ID: <20150423130409.GA4437@kroah.com> References: <1428434632-13789-1-git-send-email-pantelis.antoniou@konsulko.com> <1428434632-13789-4-git-send-email-pantelis.antoniou@konsulko.com> <6E391B8F-936A-4FD1-B8CC-C9B5FCE0B291@konsulko.com> <20150423123346.GA19166@kroah.com> <98237E9E-04CB-4CD5-8B2F-63F070B54459@konsulko.com> <20150423125441.GA32303@kroah.com> <5F0BA9FB-8345-4296-8595-0E4CD1C816AA@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5F0BA9FB-8345-4296-8595-0E4CD1C816AA@konsulko.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1017 Lines: 31 On Thu, Apr 23, 2015 at 03:59:02PM +0300, Pantelis Antoniou wrote: > >>>> It’s the same reason that the device tree core is using it. > >>> > >>> It is doing that for "raw" device tree files, not individual attributes, > >>> right? > >>> > >> > >> Each property of a device tree is a binary attribute. > > > > Because they export binary data, right? I don't have access to a > > machine that uses device tree at the moment to check this... > > > > Any specific file/function you are referring to? > > > > Yes, they export binary data. It works because the device tree nodes > are raw kobjs. Great, then the device tree is doing this correctly :) For text files, use real attribute files, that's the proper way to handle sysfs from kobjects. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/