Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757357AbbDWN2d (ORCPT ); Thu, 23 Apr 2015 09:28:33 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:33465 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757168AbbDWN2b (ORCPT ); Thu, 23 Apr 2015 09:28:31 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Adam Goode Date: Thu, 23 Apr 2015 09:28:09 -0400 Message-ID: Subject: Re: Thunderbolt hotplug not working on MacMini7,1 To: Andreas Noever Cc: "linux-kernel@vger.kernel.org" , Matthew Garrett Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1713 Lines: 44 On Thu, Apr 23, 2015 at 6:08 AM, Andreas Noever wrote: > Hi Adam, > > On my system (MacBookPro10,1 - 4 channel TB1) the bridges and the > controller both use 0x1547 and are only differentiated by > subvendor/subdevice. > > 0x156c is the 4 channel TB2 controller and was originally added by > Matthew. Judging from his patch it looks like the subvendor/subdevice > is set on his system: > http://patchwork.ozlabs.org/patch/354626/ > > But it also indicates that the bridges already use different ids. If > that is the case then we can drop the subvendor/subdevice for 0x156c. > Matthew can you confirm that on your system 0x156c is used only for > the controller? > > Adam, could you check that suspend/resume works properly? Also your > bugzilla report suggest that hotplug might now work without the > driver. Could you try to revert the _OSI check (and disable the > driver) and check whether everything "just works"? > In _OSI("Darwin") mode, suspend/resume doesn't work. It failed to come back from suspend. I have to rebuild the kernel and remove Darwin again, but I will test suspend/resume in "Windows 2012" mode later. >From previous testing, hotplug doesn't automatically work in "Windows 2012" mode. It exhibits the standard no-driver behavior where devices are not detected after boot. But even in "Windows 2012" mode I still do get the 0x156c device, which I think used to be hidden if !Darwin. More testing coming... Adam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/