Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758089AbbDWONk (ORCPT ); Thu, 23 Apr 2015 10:13:40 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:35794 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757319AbbDWONg (ORCPT ); Thu, 23 Apr 2015 10:13:36 -0400 MIME-Version: 1.0 In-Reply-To: <1429797437-23573-1-git-send-email-david.s.gordon@intel.com> References: <1429797437-23573-1-git-send-email-david.s.gordon@intel.com> Date: Thu, 23 Apr 2015 23:13:34 +0900 Message-ID: Subject: Re: [PATCH] lib/scatterlist: fix kerneldoc for sg_pcopy_{to,from}_buffer() From: Akinobu Mita To: Dave Gordon Cc: LKML , "Martin K. Petersen" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1065 Lines: 24 2015-04-23 22:57 GMT+09:00 Dave Gordon : > The kerneldoc for the functions doesn't match the code; the > last two parameters (buflen, skip) have been transposed, which > is confusing, especially as they're both integral types and the > compiler won't warn about swapping them. > > These functions and the kerneldoc were introduced in commit: > df642cea lib/scatterlist: introduce sg_pcopy_from_buffer() ... > Author: Akinobu Mita > Date: Mon Jul 8 16:01:54 2013 -0700 > > The only difference between sg_pcopy_{from,to}_buffer() and > sg_copy_{from,to}_buffer() is an additional argument that > specifies the number of bytes to skip the SG list before > copying. Thanks for fixing this. Reviewed-by: Akinobu Mita -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/