Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757998AbbDWOot (ORCPT ); Thu, 23 Apr 2015 10:44:49 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:52951 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1757733AbbDWOop (ORCPT ); Thu, 23 Apr 2015 10:44:45 -0400 Date: Thu, 23 Apr 2015 10:44:44 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Geert Uytterhoeven cc: Magnus Damm , Linux-sh list , Jason Cooper , Geert Uytterhoeven , Linux PM list , "linux-kernel@vger.kernel.org" , Simon Horman , Thomas Gleixner Subject: Re: [PATCH/RFC 00/03] irqchip: renesas-irqc: Fine grained Runtime PM support In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 26 On Thu, 23 Apr 2015, Geert Uytterhoeven wrote: > >> I'm afraid you can't call pm_runtime_get_sync() from these methods, as > >> they may be called from interrupt context. > > > > Ouch. I know the clock framework has prepare/enable separated with > > context, but with the irqchip callbacks I suppose no such separation > > It's not the clock operations, but the pm_runtime operations that cannot be > called from interrupt context. In fact the pm_runtime operations _can_ be called from interrupt context, provided the driver has first invoked pm_runtime_irq_safe(). Of course, this requires that none of the runtime-PM callback routines ever sleep or perform a blocking operation. This is all explained in Documentation/power/runtime_pm.txt (search for "irq_safe"). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/