Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030281AbbDWP3e (ORCPT ); Thu, 23 Apr 2015 11:29:34 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:33552 "EHLO mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966478AbbDWP31 (ORCPT ); Thu, 23 Apr 2015 11:29:27 -0400 Message-ID: <55390FD3.9050505@lwfinger.net> Date: Thu, 23 Apr 2015 10:29:23 -0500 From: Larry Finger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: "DHANAPAL, GNANACHANDRAN (G.)" , "gregkh@linuxfoundation.org" CC: "florian.c.schilhabel@googlemail.com" , "thomas@grouk.net" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" , "vthakkar1994@gmail.com" Subject: Re: [PATCH v2] Staging: rtl8712: Removed unused return variable References: <20150423150211.GA29501@visteon-gnana> In-Reply-To: <20150423150211.GA29501@visteon-gnana> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2594 Lines: 67 On 04/23/2015 10:00 AM, DHANAPAL, GNANACHANDRAN (G.) wrote: > This patch removes unused return variable in this file. You should hold off with V2 to give others a chance to comment. Your commit message does not exactly describe what is happening. The return variable is not unused. More accurately, you have rewritten the routine to always return a constant. I have not looked at the generated code, but I suspect that gcc is already doing that when it optimizes the code. If you really want to reduce the size of the generated code, there is no reason for this function to be of type uint. It should be type void and not return anything. Larry > > Signed-off-by: Gnanachandran Dhanapal > --- > drivers/staging/rtl8712/os_intfs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8712/os_intfs.c b/drivers/staging/rtl8712/os_intfs.c > index 6e776e5..b881368 100644 > --- a/drivers/staging/rtl8712/os_intfs.c > +++ b/drivers/staging/rtl8712/os_intfs.c > @@ -128,7 +128,6 @@ static int netdev_close(struct net_device *pnetdev); > > static uint loadparam(struct _adapter *padapter, struct net_device *pnetdev) > { > - uint status = _SUCCESS; > struct registry_priv *registry_par = &padapter->registrypriv; > > registry_par->chip_version = (u8)chip_version; > @@ -172,7 +171,7 @@ static uint loadparam(struct _adapter *padapter, struct net_device *pnetdev) > registry_par->low_power = (u8)low_power; > registry_par->wifi_test = (u8) wifi_test; > r8712_initmac = initmac; > - return status; > + return _SUCCESS; > } > > static int r871x_net_set_mac_address(struct net_device *pnetdev, void *p) > @@ -273,7 +272,6 @@ void r8712_stop_drv_timers(struct _adapter *padapter) > > static u8 init_default_value(struct _adapter *padapter) > { > - u8 ret = _SUCCESS; > struct registry_priv *pregistrypriv = &padapter->registrypriv; > struct xmit_priv *pxmitpriv = &padapter->xmitpriv; > struct mlme_priv *pmlmepriv = &padapter->mlmepriv; > @@ -306,7 +304,7 @@ static u8 init_default_value(struct _adapter *padapter) > r8712_init_registrypriv_dev_network(padapter); > r8712_update_registrypriv_dev_network(padapter); > /*misc.*/ > - return ret; > + return _SUCCESS; > } > > u8 r8712_init_drv_sw(struct _adapter *padapter) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/