Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966386AbbDWP6Q (ORCPT ); Thu, 23 Apr 2015 11:58:16 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26924 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966135AbbDWP6O (ORCPT ); Thu, 23 Apr 2015 11:58:14 -0400 Date: Thu, 23 Apr 2015 18:57:13 +0300 From: Dan Carpenter To: Larry Finger Cc: "DHANAPAL, GNANACHANDRAN (G.)" , "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "florian.c.schilhabel@googlemail.com" , "thomas@grouk.net" , "Babu, Viswanathan (V.)" , "vthakkar1994@gmail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] Staging: rtl8712: Removed unused return variable Message-ID: <20150423155713.GK14154@mwanda> References: <20150423150211.GA29501@visteon-gnana> <55390FD3.9050505@lwfinger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55390FD3.9050505@lwfinger.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 506 Lines: 16 This patch is a coccinelle thing, the reasoning behind it is that literals are more clear than variables. return status; <-- Ambiguous. This could be returning anything, you have to look at the context. return 0; <-- Clear. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/