Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966470AbbDWQHZ (ORCPT ); Thu, 23 Apr 2015 12:07:25 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:33044 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966186AbbDWQHX (ORCPT ); Thu, 23 Apr 2015 12:07:23 -0400 Date: Thu, 23 Apr 2015 18:09:29 +0200 From: Daniel Vetter To: John Hunter Cc: "yongjun_wei@trendmicro.com.cn" , "weiyj_lk@163.com" , "intel-gfx@lists.freedesktop.org" , open list , "dri-devel@lists.freedesktop.org" , Daniel Vetter Subject: Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove duplicated include from intel_audio.c Message-ID: <20150423160929.GM5082@phenom.ffwll.local> Mail-Followup-To: John Hunter , "yongjun_wei@trendmicro.com.cn" , "weiyj_lk@163.com" , "intel-gfx@lists.freedesktop.org" , open list , "dri-devel@lists.freedesktop.org" , Daniel Vetter References: <1429189868-24164-1-git-send-email-weiyj_lk@163.com> <20150416143047.GJ5082@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4486 Lines: 171 On Wed, Apr 22, 2015 at 10:50:55AM +0800, John Hunter wrote: > Sure, but I need Daniel to admit that, because maybe include the two header > file make it easier to understand. > And after checked other files in drm/i915, I found that a lot other file do > the > same thing(include both header file). So I will just wait Daniel to wait up > and > give me the order :-) drm/i915 headers are a bit a chaos anyway, so I'm not sure how useful that would be really. And generally the trend in linux (and drm) is to have split-up headers, so moving everyone to just include intel_drv.h would be the "wrong" direction. tbh I just don't have an opinion really ;-) -Daniel > > On Wed, Apr 22, 2015 at 10:35 AM, yongjun_wei@trendmicro.com.cn < > yongjun_wei@trendmicro.com.cn> wrote: > > > Hi John, > > > > > > > > Feel free to submit a new patch. > > > > > > > > Regards, > > > > Yongjun Wei > > > > > > > > *From:* John Hunter [mailto:zhjwpku@gmail.com] > > *Sent:* 2015年4月22日 10:30 > > *To:* weiyj_lk@163.com; Daniel Vetter; Jani Nikula; David Airlie; Yongjun > > Wei (RD-CN); intel-gfx@lists.freedesktop.org; > > dri-devel@lists.freedesktop.org; open list > > *Subject:* Re: [Intel-gfx] [PATCH -next] drm/i915/audio: remove > > duplicated include from intel_audio.c > > > > > > > > Hi, > > > > > > > > I think maybe we should remove both of the two lines: > > > > #include "intel_drv.h" > > > > #include "i915_drv.h" > > > > Because we have* two* "intel_drv.h" and *one* "i915_drv.h", and > > > > "i915_drv.h" has already been included in the "intel_drv.h". > > > > > > > > I not sure whether i am right. If you need me to do the patch, > > > > let me know. > > > > > > > > > > > > On Thu, Apr 16, 2015 at 10:30 PM, Daniel Vetter wrote: > > > > On Thu, Apr 16, 2015 at 09:11:08PM +0800, weiyj_lk@163.com wrote: > > > From: Wei Yongjun > > > > > > Remove duplicated include. > > > > > > Signed-off-by: Wei Yongjun > > > > Queued for -next, thanks for the patch. > > -Daniel > > > > > --- > > > drivers/gpu/drm/i915/intel_audio.c | 1 - > > > 1 file changed, 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > > b/drivers/gpu/drm/i915/intel_audio.c > > > index 2396cc7..d00d488 100644 > > > --- a/drivers/gpu/drm/i915/intel_audio.c > > > +++ b/drivers/gpu/drm/i915/intel_audio.c > > > @@ -28,7 +28,6 @@ > > > > > > #include > > > #include > > > -#include "intel_drv.h" > > > #include "i915_drv.h" > > > > > > /** > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > > Daniel Vetter > > Software Engineer, Intel Corporation > > http://blog.ffwll.ch > > > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > > > -- > > > > Best regards > > > > Junwang Zhao > > > > Microprocessor Research and Develop Center > > > > Department of Computer Science &Technology > > > > Peking University > > > > Beijing, 100871, PRC > > > > ======================================================= > > > > This message has been analyzed by Deep Discovery Email Inspector. > > > > > > > > TREND MICRO EMAIL NOTICE > > The information contained in this email and any attachments is confidential > > and may be subject to copyright or other intellectual property protection. > > If you are not the intended recipient, you are not authorized to use or > > disclose this information, and we request that you notify us by reply mail or > > telephone and delete the original message from your mail system. > > > > > > > -- > Best regards > Junwang Zhao > Microprocessor Research and Develop Center > Department of Computer Science &Technology > Peking University > Beijing, 100871, PRC > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/