Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966568AbbDWQcf (ORCPT ); Thu, 23 Apr 2015 12:32:35 -0400 Received: from mail-by2on0131.outbound.protection.outlook.com ([207.46.100.131]:6160 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966477AbbDWQcc convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2015 12:32:32 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; intel.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NN9PY3-08-JTJ-02 X-M-MSG: From: "Suthikulpanit, Suravee" To: "rjw@rjwysocki.net" , "mika.westerberg@linux.intel.com" , "robert.moore@intel.com" , "lv.zheng@intel.com" , "hanjun.guo@linaro.org" CC: "lenb@kernel.org" , "hdegoede@redhat.com" , "tj@kernel.org" , "mjg59@srcf.ucam.org" , "gregkh@linuxfoundation.org" , "al.stone@linaro.org" , "graeme.gregory@linaro.org" , "Duran, Leo" , "linux-ide@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [V8 PATCH 0/3] Introduce ACPI support for ahci_platform driver Thread-Topic: [V8 PATCH 0/3] Introduce ACPI support for ahci_platform driver Thread-Index: AQHQazRdwJIBTqPbiUKH2DJNoQuTlJ1AGjGAgBrEygA= Date: Thu, 23 Apr 2015 16:32:25 +0000 Message-ID: In-Reply-To: <5522AA0F.8000008@amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-MacOutlook/14.3.0.121105 x-originating-ip: [10.177.96.13] Content-Type: text/plain; charset="us-ascii" Content-ID: <95F9E17AAE07DD49A277AB6504D5AA13@amd.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(428002)(209900001)(51704005)(479174004)(24454002)(199003)(189002)(164054003)(377454003)(97756001)(86362001)(23726002)(87936001)(2201001)(2900100001)(5001770100001)(2950100001)(92566002)(47776003)(36756003)(101416001)(77156002)(15975445007)(102836002)(46406003)(62966003)(50466002)(19580395003)(19580405001)(50986999)(2656002)(19273905006)(19300405004)(54356999)(105586002)(106466001)(106116001)(5250100002)(2501003)(83506001)(53416004)(15395725005)(4001350100001)(46102003)(562404015)(563064011)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR02MB203;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB203; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:BY2PR02MB203;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB203; X-Forefront-PRVS: 0555EC8317 X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2015 16:32:29.0362 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB203 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5067 Lines: 130 Mika/Rafael, If there are no other concerns about this patch series, do you think this ready to be pushed to linux-next tree along with the rest of the ARM64 ACPI patch series from Linaro? Thanks, Suravee On 4/6/15, 10:45, "Suravee Suthikulanit" wrote: >Ping. > >Are there any other concerns for this patch series? > >Thanks, > >Suravee > >On 3/30/2015 4:56 PM, Suravee Suthikulpanit wrote: >> This patch series introduce ACPI support for AHCI platform driver. >> Existing ACPI support for AHCI assumes the device controller is a PCI >>device. >> Since there is no ACPI _CID for generic AHCI controller, the driver >> could not use it for matching devices. Therefore, this patch introduces >> a mechanism for drivers to match devices using ACPI _CLS method. >> _CLS contains PCI-defined class-code. >> >> This patch series also modifies ACPI modalias to add class-code to the >> exisiting format, which currently only uses _HID and _CIDs. This is >>required >> to support loadable modules w/ _CLS. >> >> This is rebased from and tested with: >> >> http://git.linaro.org/leg/acpi/acpi.git acpi-5.1-v11 >> >> This topic was discussed earlier here (as part of introducing support >>for >> AMD Seattle SATA controller): >> >> http://marc.info/?l=linux-arm-kernel&m=141083492521584&w=2 >> >> Changes from V7 (https://lkml.org/lkml/2015/3/26/592) >> * [1/3] Return AE_AML_OPERAND_TYPE when _CLS package containing >> invalid type (per Robert Moore suggestion). >> * [2/3] Fixed build error due missing ACPI_DEVICE_CLASS definition >> when disabling ACPI. >> >> Changes from V6 (https://lkml.org/lkml/2015/3/25/797) >> * Adding Acked-by Mika, and Reviewed-by Hanjun >> * Minor clen up to use lower case 0xffffff for cls_msk >> (per Mika suggestions). >> * Modify the ACPI_DEVICE_CLASS macro to use designated initializer >> (per Mika suggestions). >> >> Changes from V5 (https://lkml.org/lkml/2015/3/6/24) >> * Rebased and tested with acpi-5.1-v11 >> * Splitting up the ACPICA changes into a separate patch [1/3]. >> (per Mika suggestion) >> * Adding class-code mask support (per Mika suggestion) >> * Use macro to define struct acpi_device_id entry (per Mika suggestion) >> * Note: Mika also recommend reordering the member of struct >>acpi_device_id >> and define a macro to be used for declaring each table entry. This >>is a >> large amount of changes, and will be done separtely from this patch >>series. >> >> Changes from V4 (https://lkml.org/lkml/2015/3/2/56) >> * [1/2] Bug fixed: Reorder the declaration of >> struct acpi_pnp_device_id cls in the struct acpi_device_info >> (include/acpi/actypes.h) since compatible_id_list must be last one. >> * [2/2] Added Acked-by: Tejun Heo >> >> Changes from V3 (https://lkml.org/lkml/2015/2/8/106) >> * Instead of introducing new structure acpi_device_cls, add cls into >> the acpi_device_id, and modify the __acpi_match_device >> to also match for cls. (per Mika suggestion.) >> * Add loadable module support, which requires changes in ACPI >> modalias. (per Mika suggestion.) >> * Rebased and tested with acpi-5.1-v9 >> >> Changes from V2 (https://lkml.org/lkml/2015/1/5/662) >> * Update with review comment from Rafael in patch 1/2 >> * Rebased and tested with acpi-5.1-v8 >> >> Changes from V1 (https://lkml.org/lkml/2014/12/19/345) >> * Rebased to 3.19.0-rc2 >> * Change from acpi_cls in device_driver to acpi_match_cls (Hanjun >>comment) >> * Change the matching logic in acpi_driver_match_device() due to the >>new >> special PRP0001 _HID. >> * Simplify the return type of acpi_match_device_cls() to boolean. >> >> Changes from RFC (https://lkml.org/lkml/2014/12/17/446) >> * Remove #ifdef and make non-ACPI version of the acpi_match_device_cls >> as inline. (per Arnd) >> * Simplify logic to retrieve and evaluate _CLS handle. (per Hanjun) >> >> Suravee Suthikulpanit (3): >> ACPICA: Add ACPI _CLS processing >> ACPI / scan: Add support for ACPI _CLS device matching >> ata: ahci_platform: Add ACPI _CLS matching >> >> drivers/acpi/acpica/acutils.h | 3 ++ >> drivers/acpi/acpica/nsxfname.c | 21 +++++++++-- >> drivers/acpi/acpica/utids.c | 73 >>+++++++++++++++++++++++++++++++++++++++ >> drivers/acpi/scan.c | 36 ++++++++++++++++--- >> drivers/ata/Kconfig | 2 +- >> drivers/ata/ahci_platform.c | 9 +++++ >> include/acpi/acnames.h | 1 + >> include/acpi/actypes.h | 4 ++- >> include/linux/acpi.h | 14 ++++++++ >> include/linux/mod_devicetable.h | 2 ++ >> scripts/mod/devicetable-offsets.c | 2 ++ >> scripts/mod/file2alias.c | 32 +++++++++++++++-- >> 12 files changed, 189 insertions(+), 10 deletions(-) >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/