Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030441AbbDWRKz (ORCPT ); Thu, 23 Apr 2015 13:10:55 -0400 Received: from mailrelay1.public.one.com ([91.198.169.124]:20982 "EHLO mailrelay1.public.one.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030297AbbDWRKv (ORCPT ); Thu, 23 Apr 2015 13:10:51 -0400 X-HalOne-Cookie: 22056194170142b3fe084abbafe3cafd4fb23553 X-HalOne-ID: afac84ff-e9db-11e4-88ef-b8ca3afa9d73 Message-ID: <5539279F.4050400@bitmath.org> Date: Thu, 23 Apr 2015 19:10:55 +0200 From: Henrik Rydberg User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Dmitry Torokhov , Jiri Kosina CC: Benjamin Tissoires , "linux-input@vger.kernel.org" , lkml Subject: Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key References: <1427741655-4142-1-git-send-email-benjamin.tissoires@redhat.com> <20150406163349.GD36770@dtor-ws> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 23 > "Creation, replacement and destruction of contacts is achieved by > modifying the ABS_MT_TRACKING_ID of the associated slot. A > non-negative tracking id is interpreted as a contact, and the value -1 > denotes an unused slot. A tracking id not previously present is > considered new, and a tracking id no longer present is considered > removed." > > If some userspace is confused with missing -1 tracking ID for that > slot, that userspace should be fixed. I agree. Some userland applications work with add/remove out of convenience, and cannot handle the more compressed notation the kernel slot handling allows. Fixing those applications will be a good thing. Unfortunately the patch already appeared in Linus' tree... Henrik -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/