Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030611AbbDWSUx (ORCPT ); Thu, 23 Apr 2015 14:20:53 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:34972 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030405AbbDWSUv (ORCPT ); Thu, 23 Apr 2015 14:20:51 -0400 Date: Thu, 23 Apr 2015 11:20:46 -0700 From: Dmitry Torokhov To: Henrik Rydberg Cc: Jiri Kosina , Benjamin Tissoires , "linux-input@vger.kernel.org" , lkml Subject: Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key Message-ID: <20150423182046.GF34808@dtor-ws> References: <1427741655-4142-1-git-send-email-benjamin.tissoires@redhat.com> <20150406163349.GD36770@dtor-ws> <5539279F.4050400@bitmath.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5539279F.4050400@bitmath.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 26 On Thu, Apr 23, 2015 at 07:10:55PM +0200, Henrik Rydberg wrote: > > "Creation, replacement and destruction of contacts is achieved by > > modifying the ABS_MT_TRACKING_ID of the associated slot. A > > non-negative tracking id is interpreted as a contact, and the value -1 > > denotes an unused slot. A tracking id not previously present is > > considered new, and a tracking id no longer present is considered > > removed." > > > > If some userspace is confused with missing -1 tracking ID for that > > slot, that userspace should be fixed. > > I agree. Some userland applications work with add/remove out of convenience, and > cannot handle the more compressed notation the kernel slot handling allows. > Fixing those applications will be a good thing. > > Unfortunately the patch already appeared in Linus' tree... It's in 4.1-rc0 so we can just revert it. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/