Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030523AbbDWS4l (ORCPT ); Thu, 23 Apr 2015 14:56:41 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34438 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754254AbbDWS4h (ORCPT ); Thu, 23 Apr 2015 14:56:37 -0400 Date: Thu, 23 Apr 2015 20:56:33 +0200 From: Greg Kroah-Hartman To: Linus Torvalds Cc: Andy Lutomirski , Andrew Morton , Arnd Bergmann , "Eric W. Biederman" , One Thousand Gnomes , Tom Gundersen , Jiri Kosina , "linux-kernel@vger.kernel.org" , Daniel Mack , David Herrmann , Djalal Harouni Subject: Re: [GIT PULL] kdbus for 4.1-rc1 Message-ID: <20150423185633.GA13242@kroah.com> References: <20150413190350.GA9485@kroah.com> <20150423130548.GA4253@kroah.com> <20150423163616.GA10874@kroah.com> <20150423171640.GA11227@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2194 Lines: 52 On Thu, Apr 23, 2015 at 11:04:36AM -0700, Linus Torvalds wrote: > On Thu, Apr 23, 2015 at 10:57 AM, Linus Torvalds > wrote: > > > > If somebody is printing something, it shouldn't matter if it's "lpr" > > or "firefox http://horses.and.trannyporn.my.little.pony.com/" that > > does the printing. > > And btw, it's not just "this is information that shouldn't be logged". > > It's literally "information that should not *ever* be used". I can > easily see some phone manufacturer deciding to do "value add" by > adding a special case where a special vendor system manager program > gets a back door to some service, because it needs to access the > camera for user identification at login time, so there's some magic > > if (!strcmp(client->pid_comm, "vendor-login-pr")) > return ACCESS_OK; > > because "it was the simplest way to do this", and the programmer knew > it was a hack, but he needed to get it working because he had a > deadline yesterday. > > And then somebody figures this out, and makes an app that takes > pictures on your phone surreptitiously. > > No, we can't protect against vendors doing stupid things, but we very > much also shouldn't make the kernel have interfaces that basically > encourage people to do stupid things because they make irrelevant and > wrongheaded data available. Doing access control based on comm and cmdline is horrid, I totally agree. But right now, any process in the system can read any other process's comm and cmdline value out of /proc today. So removing it from the metadata is fine for kdbus, I can live with that, but it really isn't "preventing" anything that's not already visible to everyone, so if someone wanting to be "bad" could always still log it or do anything else they wanted with it. Doesn't syslog uses it today all over the place for logging stuff that happens in the system? Or am I missing something here? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/