Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030733AbbDWS6Q (ORCPT ); Thu, 23 Apr 2015 14:58:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55321 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030420AbbDWS6M (ORCPT ); Thu, 23 Apr 2015 14:58:12 -0400 Date: Thu, 23 Apr 2015 20:57:56 +0200 From: Thomas Huth To: Greg Kurz Cc: Rusty Russell , "Michael S. Tsirkin" , Cornelia Huck , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 2/8] tun: add tun_is_little_endian() helper Message-ID: <20150423205756.5f477b27@thh440s> In-Reply-To: <20150423152628.11795.87340.stgit@bahia.local> References: <20150423152608.11795.4373.stgit@bahia.local> <20150423152628.11795.87340.stgit@bahia.local> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1270 Lines: 40 On Thu, 23 Apr 2015 17:26:30 +0200 Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > drivers/net/tun.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/tun.c b/drivers/net/tun.c > index 857dca4..3c3d6c0 100644 > --- a/drivers/net/tun.c > +++ b/drivers/net/tun.c > @@ -206,14 +206,19 @@ struct tun_struct { > u32 flow_count; > }; > > +static inline bool tun_is_little_endian(struct tun_struct *tun) > +{ > + return tun->flags & TUN_VNET_LE; > +} > + > static inline u16 tun16_to_cpu(struct tun_struct *tun, __virtio16 val) > { > - return __virtio16_to_cpu(tun->flags & TUN_VNET_LE, val); > + return __virtio16_to_cpu(tun_is_little_endian(tun), val); > } > > static inline __virtio16 cpu_to_tun16(struct tun_struct *tun, u16 val) > { > - return __cpu_to_virtio16(tun->flags & TUN_VNET_LE, val); > + return __cpu_to_virtio16(tun_is_little_endian(tun), val); > } Reviewed-by: Thomas Huth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/