Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030773AbbDWS7q (ORCPT ); Thu, 23 Apr 2015 14:59:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51748 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030389AbbDWS7m (ORCPT ); Thu, 23 Apr 2015 14:59:42 -0400 Date: Thu, 23 Apr 2015 20:59:25 +0200 From: Thomas Huth To: Greg Kurz Cc: Rusty Russell , "Michael S. Tsirkin" , Cornelia Huck , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 3/8] macvtap: introduce macvtap_is_little_endian() helper Message-ID: <20150423205925.5bd803a3@thh440s> In-Reply-To: <20150423152638.11795.37818.stgit@bahia.local> References: <20150423152608.11795.4373.stgit@bahia.local> <20150423152638.11795.37818.stgit@bahia.local> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 39 On Thu, 23 Apr 2015 17:26:41 +0200 Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > drivers/net/macvtap.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c > index 27ecc5c..a2f2958 100644 > --- a/drivers/net/macvtap.c > +++ b/drivers/net/macvtap.c > @@ -49,14 +49,19 @@ struct macvtap_queue { > > #define MACVTAP_VNET_LE 0x80000000 > > +static inline bool macvtap_is_little_endian(struct macvtap_queue *q) > +{ > + return q->flags & MACVTAP_VNET_LE; > +} > + > static inline u16 macvtap16_to_cpu(struct macvtap_queue *q, __virtio16 val) > { > - return __virtio16_to_cpu(q->flags & MACVTAP_VNET_LE, val); > + return __virtio16_to_cpu(macvtap_is_little_endian(q), val); > } > > static inline __virtio16 cpu_to_macvtap16(struct macvtap_queue *q, u16 val) > { > - return __cpu_to_virtio16(q->flags & MACVTAP_VNET_LE, val); > + return __cpu_to_virtio16(macvtap_is_little_endian(q), val); > } Reviewed-by: Thomas Huth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/