Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030749AbbDWTdp (ORCPT ); Thu, 23 Apr 2015 15:33:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42786 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030357AbbDWTdm (ORCPT ); Thu, 23 Apr 2015 15:33:42 -0400 Date: Thu, 23 Apr 2015 21:33:39 +0200 From: "Luis R. Rodriguez" To: Rusty Russell , Julia Lawall Cc: "Luis R. Rodriguez" , akpm@linux-foundation.org, mingo@kernel.org, tj@kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, keescook@chromium.org, casey@schaufler-ca.com, cocci@systeme.lip6.fr, Jani Nikula Subject: Re: [PATCH v2 4/8] moduleparam.h: add module_param_config_*() helpers Message-ID: <20150423193339.GO5622@wotan.suse.de> References: <1429739711-9415-1-git-send-email-mcgrof@do-not-panic.com> <1429739711-9415-5-git-send-email-mcgrof@do-not-panic.com> <87618noaj6.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87618noaj6.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1947 Lines: 49 On Thu, Apr 23, 2015 at 11:45:09AM +0930, Rusty Russell wrote: > "Luis R. Rodriguez" writes: > > From: "Luis R. Rodriguez" > > > > This adds a couple of bool module_param_config_*() helpers > > which are designed to let us easily associate a boolean > > module parameter with an associated kernel configuration > > option. > > OK. So this is really the main gain. > > Folks can use this to avoid what typically would > > be #ifdef eyesores around module parameter declarations. > > Really? So you use this in two patches: > > /* see the comment above the definition of WQ_POWER_EFFICIENT */ > -static bool wq_power_efficient = IS_ENABLED(CONFIG_WQ_POWER_EFFICIENT_DEFAULT); > -module_param_named(power_efficient, wq_power_efficient, bool, 0444); > +module_param_config_on_off(power_efficient, wq_power_efficient, 0444, CONFIG_WQ_POWER_EFFICIENT_DEFAULT); > > And: > > static bool sig_enforce = IS_ENABLED(CONFIG_MODULE_SIG_FORCE); > #ifndef CONFIG_MODULE_SIG_FORCE > -module_param(sig_enforce, bool_enable_only, 0644); > +module_param_config_on(sig_enforce, sig_enforce, 0644, CONFIG_MODULE_SIG_FORCE); > #endif /* !CONFIG_MODULE_SIG_FORCE */ > > But neither actually, y'know, cleans up any #ifdefs. OK, sure, its the use of IS_ENABLED() that does that as a first step. > Simplicity is a major virtue. Readability is a major virtue. Brevity > is only a minor virtue. I was not shooting for brevity but instead aiming at the possible grammatical gain of direct and immediate association between a bool, behaviour (on_off, or just on), and a config. I don't have a need for the grammatical association now so will drop this. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/