Date: Thu, 23 Apr 2015 21:35:38 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: LABBE Corentin <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
        linux@arm.linux.org.uk, herbert@gondor.apana.org.au,
        davem@davemloft.net, akpm@linux-foundation.org,
        gregkh@linuxfoundation.org, mchehab@osg.samsung.com, joe@perches.com,
        tj@kernel.org, jg1.han@samsung.com, arnd@arndb.de,
        devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v8 2/4] ARM: sunxi: dt: Add DT bindings documentation for
 SUNXI Security System
Message-ID: <20150423193538.GF28007@lukather>
References: <1429771523-2936-1-git-send-email-clabbe.montjoie@gmail.com>
 <1429771523-2936-3-git-send-email-clabbe.montjoie@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="XIiC+We3v3zHqZ6Z"
Content-Disposition: inline
In-Reply-To: <1429771523-2936-3-git-send-email-clabbe.montjoie@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2732
Lines: 74


--XIiC+We3v3zHqZ6Z
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2015 at 08:45:21AM +0200, LABBE Corentin wrote:
> This patch adds documentation for Device-Tree bindings for the Security S=
ystem cryptographic accelerator driver.
>=20
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
>  Documentation/devicetree/bindings/crypto/sunxi-ss.txt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/sunxi-ss.txt
>=20
> diff --git a/Documentation/devicetree/bindings/crypto/sunxi-ss.txt b/Docu=
mentation/devicetree/bindings/crypto/sunxi-ss.txt
> new file mode 100644
> index 0000000..a566803
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/sunxi-ss.txt
> @@ -0,0 +1,9 @@
> +* Allwinner Security System found on A20 SoC
> +
> +Required properties:
> +- compatible : Should be "allwinner,sun7i-a20-crypto".
> +- reg: Should contain the Security System register location and length.
> +- interrupts: Should contain the IRQ line for the Security System.
> +- clocks : A phandle to the functional clock node of the Security System=
 module

You actually need two clock references, not just a single phandle.

> +- clock-names : Name of the functional clock, should be "ahb" and "mod".

And we usually have an example after too.

Thanks!
Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--XIiC+We3v3zHqZ6Z
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVOUmKAAoJEBx+YmzsjxAguuIP/RyLc7NHFaq4e0qD/LgQurde
Wt508+jYseMWJZcBrPkiCPm8DnDIuxYqbsC08w61QPHgpWqIpyIJQUJPOgDCZGWJ
5GrmcAWHddPqlHmhAk5H+4a1tQhhk4mXmTjHB9AmdAPQ5CfFurWxuC+UNegxH83E
rIsS/HNG03EPHx9KmLJrD+a+yD0Q0zuQnUjljRuWMXwq+bq6YwrNfMPftVhkRmNJ
6pmBDTjgJQ/d68P5nIY5Y8jXofZp7zQosyvRgDUfGwQz+j+agNvMJAjTgwJF8SqJ
JK3VwgDZBhq8YQ/ZI7U5UWYRchrDFtCjCuIz6bopxgfqcDG9t8MfRqOSV34x/h4t
GgFqnrzjRfBB/aRh6a9iY0WK3SonQYJpsR3XCxTetc3RA3KfA0QaWe1g8dnREQ97
+s0349yLuzI6aGMfoabg6hv+gVqK2J21pUldDSGRkXjoEVVYPRFnlfL+HHgo0c2e
NYnZKHXrwuqJUsRLSPz+RMqjg3orO1heDiE9tAxByqImJmJ3c9i0T5ZtsvtId1Bg
DhTJcV+umdO+/9KTe1BovIpVr2cUMAogSKKM3W+ji5j4jMeoZjyi7Sf7Ah8BleIf
SBkZImCWwhfCC0iErGbrQOt+6Icv5/BqAKwaMNgIFoPW9UbJEDSrfITVWY9lS+Y/
OsvNHtBlo8xu8Ymmuawv
=7x3/
-----END PGP SIGNATURE-----

--XIiC+We3v3zHqZ6Z--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/