Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030876AbbDWTwU (ORCPT ); Thu, 23 Apr 2015 15:52:20 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:39560 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030497AbbDWTwR (ORCPT ); Thu, 23 Apr 2015 15:52:17 -0400 Date: Thu, 23 Apr 2015 14:50:43 -0500 From: Josh Cartwright To: Punnaiah Choudary Kalluri Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net, michal.simek@xilinx.com, grant.likely@linaro.org, gregkh@linuxfoundation.org, jason@lakedaemon.net, ezequiel.garcia@free-electrons.com, arnd@arndb.de, dwmw2@infradead.org, computersforpeace@gmail.com, artem.bityutskiy@linux.intel.com, jussi.kivilinna@iki.fi, acourbot@nvidia.com, ivan.khoronzhuk@ti.com, joern@logfs.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, kpc528@gmail.com, kalluripunnaiahchoudary@gmail.com, Punnaiah Choudary Kalluri Subject: Re: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information Message-ID: <20150423195043.GS27115@jcartwri.amer.corp.natinst.com> References: <1428941512-26411-1-git-send-email-punnaia@xilinx.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/23/2015 02:50:44 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 04/23/2015 02:50:44 PM, Serialize complete at 04/23/2015 02:50:44 PM Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UlsYxwg8UDQn+EKZ" Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-04-23_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2013 Lines: 60 --UlsYxwg8UDQn+EKZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hey Punnaiah- A few nitpicks here, in case you'll be spinning up a new version of your patchset. On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote: > Add pl353 static memory controller devicetree binding information. > > Signed-off-by: Punnaiah Choudary Kalluri [..] > @@ -0,0 +1,37 @@ > +Device tree bindings for ARM PL353 static memory controller > + > +PL353 static memory controller supports two kinds of memory > +interfaces. i.e NAND and SRAM/NOR interfaces. > +The actual devices are instantiated from the child nodes of pl353 smc node. > + > +Required properties: > +- compatible : Should be "arm,pl353-smc-r2p1" > +- reg : Controller registers map and length. > +- clock-names : List of input clock names - "memclk", "aclk" > + (See clock bindings for details). > +- clocks : Clock phandles (see clock bindings for details). Technically not clock phandles, but clock specifiers. > +- address-cells : Address cells, must be 1. > +- size-cells : Size cells. Must be 1. These should have the leading '#' as in '#address-cells' and '#size-cells'. Josh --UlsYxwg8UDQn+EKZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAABCAAGBQJVOU0OAAoJEKp7ZBKwQFArRsoH/jqayKE/frgryBvVuVL0NglS 6XHfvrHFZLA56uC5ourwK1L88F6lg0lJK73uPLy7e5ag2buXgbe1r0CVqn9QrszT fFpTAehqnvPRm7uUa4CKo8de6iI3G6GetEaToEsIBzPrP+I3zk91/legfVwEE81O 92FAvLgOT73rUoC700Zp5bPmEqPCzjw01CFhh6aKomIWgG3GJDO0dqgwN/WPOsN9 IMqMZpjTPhJXu2HjVk6JYQUi6kFfmWxGJtde7o8HKEB/lJp66dDn5weJNNQF3eaF tsky9+z9AkfdGlfJGzA3nsMuz8pVY1JobONszH/wWGN16o4MC+d7lJ+dWRFrWI0= =fjRC -----END PGP SIGNATURE----- --UlsYxwg8UDQn+EKZ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/