Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758340AbbDWUKc (ORCPT ); Thu, 23 Apr 2015 16:10:32 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:38166 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758311AbbDWUK0 (ORCPT ); Thu, 23 Apr 2015 16:10:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140804130339.GA1178@gondor.apana.org.au> <20141007131826.GA29688@gondor.apana.org.au> <20141211125119.GA12380@gondor.apana.org.au> <20150214094328.GA7457@gondor.apana.org.au> <20150415033951.GA1406@gondor.apana.org.au> <20150416024252.GA11558@gondor.apana.org.au> <20150416030713.GA11668@gondor.apana.org.au> Date: Thu, 23 Apr 2015 22:10:26 +0200 Message-ID: Subject: Re: Crypto Update for 4.1 From: Ard Biesheuvel To: Bobby Powers Cc: Linus Torvalds , Herbert Xu , Stephan Mueller , "David S. Miller" , Linux Kernel Mailing List , Linux Crypto Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 46 On 23 April 2015 at 21:27, Bobby Powers wrote: > Hello, > > Linus Torvalds wrote: >> Ok, this patch seems to fix it for me, so I undid my revert that I >> hadn't pushed out yet, and pushed out this instead. > > Commit e68410ebf62676dfb93aafff7c55b76644f37072 in Linus's tree from > this crpyto update (crypto: x86/sha512_ssse3 - move SHA-384/512 SSSE3 > implementation to base layer) causes a GPF on boot in > sha512_ssse3_finup for me on a Broadwell i7-5600U, rendering the > kernel unbootable. > > Reverting that commit enables me to boot. I don't know enough about > the code to comment. Config is attached, and I can provide a photo of > the reported Call Trace if thats helpful. It is quite reproducible > for me. > Hello Bobby, Would you be able to check whether the following patch fixes the crash? diff --git a/arch/x86/crypto/sha512-avx2-asm.S b/arch/x86/crypto/sha512-avx2-asm.S index a4771dcd1fcf..1f20b35d8573 100644 --- a/arch/x86/crypto/sha512-avx2-asm.S +++ b/arch/x86/crypto/sha512-avx2-asm.S @@ -79,7 +79,7 @@ NUM_BLKS = %rdx c = %rcx d = %r8 e = %rdx -y3 = %rdi +y3 = %rsi TBL = %rbp If not, please share the call trace and the content of /proc/cpuinfo Regards, Ard. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/