Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbbDXAmu (ORCPT ); Thu, 23 Apr 2015 20:42:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36215 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750765AbbDXAmq (ORCPT ); Thu, 23 Apr 2015 20:42:46 -0400 Message-ID: <5539916E.80809@redhat.com> Date: Thu, 23 Apr 2015 19:42:22 -0500 From: Dean Nelson User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Naoya Horiguchi CC: Andrew Morton , Andi Kleen , Andrea Arcangeli , Hidetoshi Seto , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] mm/hwpoison-inject: check PageLRU of hpage References: <1429236509-8796-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1429236509-8796-2-git-send-email-n-horiguchi@ah.jp.nec.com> In-Reply-To: <1429236509-8796-2-git-send-email-n-horiguchi@ah.jp.nec.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1391 Lines: 42 On 04/16/2015 09:08 PM, Naoya Horiguchi wrote: > Hwpoison injector checks PageLRU of the raw target page to find out whether > the page is an appropriate target, but current code now filters out thp tail > pages, which prevents us from testing for such cases via this interface. > So let's check hpage instead of p. > > Signed-off-by: Naoya Horiguchi Acked-by: Dean Nelson > --- > mm/hwpoison-inject.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git v4.0.orig/mm/hwpoison-inject.c v4.0/mm/hwpoison-inject.c > index 2b3f933e3282..4ca5fe0042e1 100644 > --- v4.0.orig/mm/hwpoison-inject.c > +++ v4.0/mm/hwpoison-inject.c > @@ -34,12 +34,12 @@ static int hwpoison_inject(void *data, u64 val) > if (!hwpoison_filter_enable) > goto inject; > > - if (!PageLRU(p) && !PageHuge(p)) > - shake_page(p, 0); > + if (!PageLRU(hpage) && !PageHuge(p)) > + shake_page(hpage, 0); > /* > * This implies unable to support non-LRU pages. > */ > - if (!PageLRU(p) && !PageHuge(p)) > + if (!PageLRU(hpage) && !PageHuge(p)) > goto put_out; > > /* > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/