Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752172AbbDXAqm (ORCPT ); Thu, 23 Apr 2015 20:46:42 -0400 Received: from mail-bn1on0090.outbound.protection.outlook.com ([157.56.110.90]:29216 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751319AbbDXAqh convert rfc822-to-8bit (ORCPT ); Thu, 23 Apr 2015 20:46:37 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; gmail.com; dkim=none (message not signed) header.d=none; From: Punnaiah Choudary Kalluri To: Josh Cartwright CC: "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rob@landley.net" , Michal Simek , "grant.likely@linaro.org" , "gregkh@linuxfoundation.org" , "jason@lakedaemon.net" , "ezequiel.garcia@free-electrons.com" , "arnd@arndb.de" , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "artem.bityutskiy@linux.intel.com" , "jussi.kivilinna@iki.fi" , "acourbot@nvidia.com" , "ivan.khoronzhuk@ti.com" , "joern@logfs.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "kpc528@gmail.com" , "kalluripunnaiahchoudary@gmail.com" Subject: RE: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information Thread-Topic: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree binding information Thread-Index: AQHQff8FfELB3yAuoEGSFImb/8P5sZ1bU8wA Date: Fri, 24 Apr 2015 00:46:21 +0000 References: <1428941512-26411-1-git-send-email-punnaia@xilinx.com> <20150423195043.GS27115@jcartwri.amer.corp.natinst.com> In-Reply-To: <20150423195043.GS27115@jcartwri.amer.corp.natinst.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.229.50] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-7.5.0.1018-21498.005 X-TM-AS-User-Approved-Sender: Yes;Yes;Yes Message-ID: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(438002)(13464003)(51704005)(199003)(43544003)(24454002)(377454003)(51914003)(189002)(50986999)(53416004)(87936001)(76176999)(62966003)(54356999)(77156002)(19580405001)(19580395003)(6806004)(2656002)(86362001)(47776003)(110136001)(106466001)(46102003)(104016003)(31696002)(97756001)(92566002)(50466002)(74316001)(106116001)(70736001)(2950100001)(1496007)(46406003)(23726002)(102836002)(33646002)(107986001)(23106004);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1AFFO11HUB036;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB036; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006)(3002001);SRVR:BN1AFFO11HUB036;BCL:0;PCL:0;RULEID:;SRVR:BN1AFFO11HUB036; X-Forefront-PRVS: 05568D1FF7 X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2015 00:46:26.7303 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1AFFO11HUB036 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2434 Lines: 63 Hi Josh, > -----Original Message----- > From: Josh Cartwright [mailto:joshc@ni.com] > Sent: Friday, April 24, 2015 1:21 AM > To: Punnaiah Choudary Kalluri > Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; > ijc+devicetree@hellion.org.uk; galak@codeaurora.org; rob@landley.net; > Michal Simek; grant.likely@linaro.org; gregkh@linuxfoundation.org; > jason@lakedaemon.net; ezequiel.garcia@free-electrons.com; > arnd@arndb.de; dwmw2@infradead.org; computersforpeace@gmail.com; > artem.bityutskiy@linux.intel.com; jussi.kivilinna@iki.fi; > acourbot@nvidia.com; ivan.khoronzhuk@ti.com; joern@logfs.org; > devicetree@vger.kernel.org; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-mtd@lists.infradead.org; kpc528@gmail.com; > kalluripunnaiahchoudary@gmail.com; Punnaiah Choudary Kalluri > Subject: Re: [PATCH v6 1/2] Devicetree: Add pl353 smc controller devicetree > binding information > > Hey Punnaiah- > > A few nitpicks here, in case you'll be spinning up a new version of your > patchset. > > On Mon, Apr 13, 2015 at 09:41:51PM +0530, Punnaiah Choudary Kalluri wrote: > > Add pl353 static memory controller devicetree binding information. > > > > Signed-off-by: Punnaiah Choudary Kalluri > [..] > > @@ -0,0 +1,37 @@ > > +Device tree bindings for ARM PL353 static memory controller > > + > > +PL353 static memory controller supports two kinds of memory > > +interfaces. i.e NAND and SRAM/NOR interfaces. > > +The actual devices are instantiated from the child nodes of pl353 smc > node. > > + > > +Required properties: > > +- compatible : Should be "arm,pl353-smc-r2p1" > > +- reg : Controller registers map and length. > > +- clock-names : List of input clock names - "memclk", "aclk" > > + (See clock bindings for details). > > +- clocks : Clock phandles (see clock bindings for details). > > Technically not clock phandles, but clock specifiers. > > > +- address-cells : Address cells, must be 1. > > +- size-cells : Size cells. Must be 1. > > These should have the leading '#' as in '#address-cells' and > '#size-cells'. Thanks for the review. I will take care of them new version Regards, Punnaiah > > Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/