Date: Fri, 24 Apr 2015 08:36:03 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>, gnomes@lxorguk.ukuu.org.uk, teg@jklm.no,
        jkosina@suse.cz, luto@amacapital.net, linux-kernel@vger.kernel.org,
        daniel@zonque.org, dh.herrmann@gmail.com, tixxdz@opendz.org
Subject: Re: [GIT PULL] kdbus for 4.1-rc1
Message-ID: <20150424063603.GA4790@kroah.com>
References: <20150413190350.GA9485@kroah.com>
 <8738434yjk.fsf@x220.int.ebiederm.org>
 <20150422085827.GA6962@pd.tnic>
 <20150423191433.GB13607@kroah.com>
 <20150423205640.GR28327@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150423205640.GR28327@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 853
Lines: 21

On Thu, Apr 23, 2015 at 10:56:40PM +0200, Borislav Petkov wrote:
> > Hm, this seems to be to be O(1), pretty constant, we do the same amount
> > of work all the time.
> 
> The same *pile* of unnecessary and needless work. You go and collect
> *all* that data on *every* packet send?!

No, not at all, the metadata is cached, we only collect that for the
first message sent, if we didn't know it already, or we do it on the
"open" of the connection, depending on what we are gathering metadata
for.

The mc->collected test right before collecting the specific metadata is
that "cached or not" test.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/