Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754888AbbDXGuJ (ORCPT ); Fri, 24 Apr 2015 02:50:09 -0400 Received: from mail-la0-f41.google.com ([209.85.215.41]:34616 "EHLO mail-la0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752977AbbDXGuF (ORCPT ); Fri, 24 Apr 2015 02:50:05 -0400 MIME-Version: 1.0 In-Reply-To: <20150423125620.GB29702@leverpostej> References: <1429522047-16675-1-git-send-email-pi-cheng.chen@linaro.org> <1429522047-16675-2-git-send-email-pi-cheng.chen@linaro.org> <20150423125620.GB29702@leverpostej> Date: Fri, 24 Apr 2015 14:50:04 +0800 Message-ID: Subject: Re: [PATCH 1/2] cpufreq: mediatek: Add MT8173 cpufreq driver From: Pi-Cheng Chen To: Mark Rutland Cc: Viresh Kumar , Mike Turquette , Matthias Brugger , "Joe.C" , Eddie Huang , Howard Chen , "fan.chen@mediatek.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linaro-kernel@lists.linaro.org" , "linux-mediatek@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 48 On Thu, Apr 23, 2015 at 8:56 PM, Mark Rutland wrote: >> +/* >> + * This is a temporary solution until we have new OPPv2 bindings. Therefore we >> + * could describe the OPPs with (freq, volt, volt) tuple properly in device >> + * tree. >> + */ >> + >> +/* OPP table for LITTLE cores of MT8173 */ >> +struct mtk_cpu_opp mt8173_l_opp[] = { >> + OPP(507000000, 859000, 0), >> + OPP(702000000, 908000, 0), >> + OPP(1001000000, 983000, 0), >> + OPP(1105000000, 1009000, 0), >> + OPP(1183000000, 1028000, 0), >> + OPP(1404000000, 1083000, 0), >> + OPP(1508000000, 1109000, 0), >> + OPP(1573000000, 1125000, 0), >> +}; >> + >> +/* OPP table for big cores of MT8173 */ >> +struct mtk_cpu_opp mt8173_b_opp[] = { >> + OPP(507000000, 828000, 928000), >> + OPP(702000000, 867000, 967000), >> + OPP(1001000000, 927000, 1027000), >> + OPP(1209000000, 968000, 1068000), >> + OPP(1404000000, 1007000, 1107000), >> + OPP(1612000000, 1049000, 1149000), >> + OPP(1807000000, 1089000, 1150000), >> + OPP(1989000000, 1125000, 1150000), >> +}; > > We should sort out the OPP bindings if we need to sort out the OPP > bindings. We can't remove these once they're in without causing pain for > everyone with an old DTB. So even we have a new OPP binding to describe the OPP, we have to leave these table as they are for backward compatibility? Best Regards, Pi-Cheng > > Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/