Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965200AbbDXHGY (ORCPT ); Fri, 24 Apr 2015 03:06:24 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:57231 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933412AbbDXHGX (ORCPT ); Fri, 24 Apr 2015 03:06:23 -0400 Date: Fri, 24 Apr 2015 00:06:11 -0700 From: Christoph Hellwig To: Ming Lin Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Kent Overstreet , Jens Axboe , Dongsu Park , "Hans J. Koch" , Greg Kroah-Hartman , Al Viro Subject: Re: [PATCH v3 1/4] block: refactor iov_count_pages() from bio_{copy,map}_user_iov() Message-ID: <20150424070611.GA8648@infradead.org> References: <1429830275-6792-1-git-send-email-mlin@kernel.org> <1429830275-6792-2-git-send-email-mlin@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429830275-6792-2-git-send-email-mlin@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 18 On Thu, Apr 23, 2015 at 04:04:32PM -0700, Ming Lin wrote: > From: Kent Overstreet > > Refactor the common part in bio_copy_user_iov() and > __bio_map_user_iov() to separate out iov_count_pages() into the general > iov_iter API, instead of open coding iov iterations as done previously. > > This commit should contain only literal replacements, without > functional changes. Weve already got a iov_iter_npages and iov_iter_alignment, the SG_IO code should probably be switched to those instead. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/