Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965177AbbDXIJu (ORCPT ); Fri, 24 Apr 2015 04:09:50 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:47779 "EHLO e06smtp16.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934131AbbDXIJZ (ORCPT ); Fri, 24 Apr 2015 04:09:25 -0400 Date: Fri, 24 Apr 2015 10:09:16 +0200 From: Cornelia Huck To: Greg Kurz Cc: Rusty Russell , "Michael S. Tsirkin" , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 7/8] vhost: cross-endian support for legacy devices Message-ID: <20150424100916.3d18d12c.cornelia.huck@de.ibm.com> In-Reply-To: <20150424100619.665e8bf8@bahia.local> References: <20150423152608.11795.4373.stgit@bahia.local> <20150423152915.11795.13921.stgit@bahia.local> <20150424091926.1f5dee0b.cornelia.huck@de.ibm.com> <20150424100619.665e8bf8@bahia.local> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042408-0025-0000-0000-000004DE2ADB Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1314 Lines: 42 On Fri, 24 Apr 2015 10:06:19 +0200 Greg Kurz wrote: > On Fri, 24 Apr 2015 09:19:26 +0200 > Cornelia Huck wrote: > > > On Thu, 23 Apr 2015 17:29:42 +0200 > > Greg Kurz wrote: > > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > > > index bb6a5b4..b980b53 100644 > > > --- a/include/uapi/linux/vhost.h > > > +++ b/include/uapi/linux/vhost.h > > > @@ -103,6 +103,18 @@ struct vhost_memory { > > > /* Get accessor: reads index, writes value in num */ > > > #define VHOST_GET_VRING_BASE _IOWR(VHOST_VIRTIO, 0x12, struct vhost_vring_state) > > > > > > +/* Set the vring byte order in num. Valid values are VHOST_VRING_LITTLE_ENDIAN > > > + * or VHOST_VRING_BIG_ENDIAN (other values return EINVAL). > > > > -EINVAL? > > > > Oops, yes. :) > > > Should you also mention when you return -EBUSY? > > > > Indeed... what about: > > "The byte order cannot be changed when the device is active: trying to do so > returns -EBUSY." s/when/while/ ? But sounds good. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/