From: Dexuan Cui <decui@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, KY Srinivasan <kys@microsoft.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to
 vmbus_process_offer()
Thread-Topic: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to
 vmbus_process_offer()
Thread-Index: AQHQfD9f9gBdL4xeuk+qZghgoFxoUp1bwxwA
Date: Fri, 24 Apr 2015 08:38:25 +0000
Message-ID: <a8774fcbc7234e6e8c05b7ad7c00141c@SIXPR30MB031.064d.mgd.msft.net>
References: <1429626460-7947-1-git-send-email-vkuznets@redhat.com>
 <1429626460-7947-5-git-send-email-vkuznets@redhat.com>
In-Reply-To: <1429626460-7947-5-git-send-email-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2015 08:38:33.2280
 (UTC)
X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[206.191.229.116];Helo=[064-smtp-out.microsoft.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1321
X-OriginatorOrg: microsoft.onmicrosoft.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1091
Lines: 26

> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com]
> Sent: Tuesday, April 21, 2015 22:28
> To: KY Srinivasan
> Cc: Haiyang Zhang; devel@linuxdriverproject.org; linux-
> kernel@vger.kernel.org; Dexuan Cui
> Subject: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to
> vmbus_process_offer()
> 
> We need to call init_vp_index() after we added the channel to the
> appropriate
> list (global or subchannel) to be able to use this information when assigning
> the channel to the particular vcpu. To do so we need to move a couple of
> functions around. The only real change is the init_vp_index() call. This is a
> small refactoring without a functional change.

IMO we don't have to move such a big block of code -- we only need to add a
forward function declaration of init_vp_index()?

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/